Move the Widget hierarchy to the Oilpan heap.

Source/web/PopupContainer.cpp

 /*
  * Copyright (c) 2011, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 66 matching lines @@
 
     // FIXME: This is a horrible hack since PlatformWheelEvent has no setters for x/y.
     PlatformWheelEvent relativeEvent = e;
     IntPoint& relativePos = const_cast<IntPoint&>(relativeEvent.position());
     relativePos.setX(pos.x());
     relativePos.setY(pos.y());
     return relativeEvent;
 }
 
 // static
-PassRefPtr<PopupContainer> PopupContainer::create(PopupMenuClient* client, bool deviceSupportsTouch)
+PassRefPtrWillBeRawPtr<PopupContainer> PopupContainer::create(PopupMenuClient* client, bool deviceSupportsTouch)
 {
-    return adoptRef(new PopupContainer(client, deviceSupportsTouch));
+    return adoptRefWillBeNoop(new PopupContainer(client, deviceSupportsTouch));
 }
 
 PopupContainer::PopupContainer(PopupMenuClient* client, bool deviceSupportsTouch)
     : m_listBox(PopupListBox::create(client, deviceSupportsTouch, this))
     , m_popupOpen(false)
     , m_client(0)
 {
 }
 
 PopupContainer::~PopupContainer()
 {
+#if !ENABLE(OILPAN)
+    // FIXME: can ~PopupListBox take care this?

[haraken, 2014/09/26 09:19:25]

I'm not sure if this is a FIXME.

Now that the PopupListBox and the PopupContainer live and die together, we don't
need the setParent(0) code in the destructor, do we?

[sof, 2014/09/28 15:11:26]

It's a non-Oilpan FIXME, but I will just leave it be & have removed the
question. It is tidier to remove yourself as parent in the dtor, and perhaps
this is somehow needed should the listbox be able to survive past this
PopupContainer. ?

(Not an issue with Oilpan, as the two will be finalized in the same sweep.)

     if (m_listBox->parent())
         m_listBox->setParent(0);
+#endif
+}
+
+void PopupContainer::trace(Visitor* visitor)
+{
+    visitor->trace(m_frameView);
+    visitor->trace(m_listBox);
+    Widget::trace(visitor);
 }
 
 IntRect PopupContainer::layoutAndCalculateWidgetRectInternal(IntRect widgetRectInScreen, int targetControlHeight, const FloatRect& windowRect, const FloatRect& screen, bool isRTL, const int rtlOffset, const int verticalOffset, const IntSize& transformOffset, PopupContent* listBox, bool& needToResizeView)
 {
     ASSERT(listBox);
     if (windowRect.x() >= screen.x() && windowRect.maxX() <= screen.maxX() && (widgetRectInScreen.x() < screen.x() || widgetRectInScreen.maxX() > screen.maxX())) {
         // First, inverse the popup alignment if it does not fit the screen -
         // this might fix things (or make them better).
         IntRect inverseWidgetRectInScreen = widgetRectInScreen;
         inverseWidgetRectInScreen.setX(inverseWidgetRectInScreen.x() + (isRTL ? -rtlOffset : rtlOffset));
@@ skipping 165 matching lines @@
 
 bool PopupContainer::handleMouseMoveEvent(const PlatformMouseEvent& event)
 {
     UserGestureIndicator gestureIndicator(DefinitelyProcessingNewUserGesture);
     return m_listBox->handleMouseMoveEvent(
         constructRelativeMouseEvent(event, this, m_listBox.get()));
 }
 
 bool PopupContainer::handleMouseReleaseEvent(const PlatformMouseEvent& event)
 {
-    RefPtr<PopupContainer> protect(this);
+    RefPtrWillBeRawPtr<PopupContainer> protect(this);
     UserGestureIndicator gestureIndicator(DefinitelyProcessingNewUserGesture);
     return m_listBox->handleMouseReleaseEvent(
         constructRelativeMouseEvent(event, this, m_listBox.get()));
 }
 
 bool PopupContainer::handleWheelEvent(const PlatformWheelEvent& event)
 {
     UserGestureIndicator gestureIndicator(DefinitelyProcessingNewUserGesture);
     return m_listBox->handleWheelEvent(
         constructRelativeWheelEvent(event, this, m_listBox.get()));
@@ skipping 250 matching lines @@
 }
 
 IntPoint PopupContainer::convertSelfToChild(const Widget* child, const IntPoint& point) const
 {
     IntPoint newPoint = point;
     newPoint.moveBy(-child->location());
     return newPoint;
 }
 
 } // namespace blink