Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Side by Side Diff: Source/core/rendering/RenderScrollbar.h

Issue 603193005: Move the Widget hierarchy to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Support renderer-less plugin disposal Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008, 2009 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008, 2009 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
11 * documentation and/or other materials provided with the distribution. 11 * documentation and/or other materials provided with the distribution.
12 * 12 *
13 * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY 13 * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR 16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR
17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, 17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, 18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR 19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY 20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24 */ 24 */
25 25
26 #ifndef RenderScrollbar_h 26 #ifndef RenderScrollbar_h
27 #define RenderScrollbar_h 27 #define RenderScrollbar_h
28 28
29 #include "core/rendering/style/RenderStyleConstants.h" 29 #include "core/rendering/style/RenderStyleConstants.h"
30 #include "platform/heap/Handle.h"
30 #include "platform/scroll/Scrollbar.h" 31 #include "platform/scroll/Scrollbar.h"
31 #include "wtf/HashMap.h" 32 #include "wtf/HashMap.h"
32 33
33 namespace blink { 34 namespace blink {
34 35
35 class LocalFrame; 36 class LocalFrame;
36 class Node; 37 class Node;
37 class RenderBox; 38 class RenderBox;
38 class RenderScrollbarPart; 39 class RenderScrollbarPart;
39 class RenderStyle; 40 class RenderStyle;
40 41
41 class RenderScrollbar final : public Scrollbar { 42 class RenderScrollbar final : public Scrollbar {
42 protected: 43 #if ENABLE(OILPAN)
43 RenderScrollbar(ScrollableArea*, ScrollbarOrientation, Node*, LocalFrame*); 44 USING_PRE_FINALIZER(RenderScrollbar, destroyParts);
44 45 #endif
45 public: 46 public:
46 friend class Scrollbar; 47 static PassRefPtrWillBeRawPtr<Scrollbar> createCustomScrollbar(ScrollableAre a*, ScrollbarOrientation, Node*, LocalFrame* owningFrame = 0);
47 static PassRefPtr<Scrollbar> createCustomScrollbar(ScrollableArea*, Scrollba rOrientation, Node*, LocalFrame* owningFrame = 0);
48 virtual ~RenderScrollbar(); 48 virtual ~RenderScrollbar();
49 49
50 RenderBox* owningRenderer() const; 50 RenderBox* owningRenderer() const;
51 51
52 IntRect buttonRect(ScrollbarPart); 52 IntRect buttonRect(ScrollbarPart);
53 IntRect trackRect(int startLength, int endLength); 53 IntRect trackRect(int startLength, int endLength);
54 IntRect trackPieceRectWithMargins(ScrollbarPart, const IntRect&); 54 IntRect trackPieceRectWithMargins(ScrollbarPart, const IntRect&);
55 55
56 int minimumThumbLength(); 56 int minimumThumbLength();
57 57
58 virtual bool isOverlayScrollbar() const override { return false; } 58 virtual bool isOverlayScrollbar() const override { return false; }
59 59
60 RenderScrollbarPart* getPart(ScrollbarPart partType) { return m_parts.get(pa rtType); } 60 RenderScrollbarPart* getPart(ScrollbarPart partType) { return m_parts.get(pa rtType); }
61 61
62 virtual void trace(Visitor*) override;
63
64 protected:
65 RenderScrollbar(ScrollableArea*, ScrollbarOrientation, Node*, LocalFrame*);
66
62 private: 67 private:
68 friend class Scrollbar;
69
63 virtual void setParent(Widget*) override; 70 virtual void setParent(Widget*) override;
64 virtual void setEnabled(bool) override; 71 virtual void setEnabled(bool) override;
65 72
66 virtual void setHoveredPart(ScrollbarPart) override; 73 virtual void setHoveredPart(ScrollbarPart) override;
67 virtual void setPressedPart(ScrollbarPart) override; 74 virtual void setPressedPart(ScrollbarPart) override;
68 75
69 virtual void styleChanged() override; 76 virtual void styleChanged() override;
70 77
71 virtual bool isCustomScrollbar() const override { return true; } 78 virtual bool isCustomScrollbar() const override { return true; }
72 79
73 void updateScrollbarParts(bool destroy = false); 80 void updateScrollbarParts(bool destroy = false);
74 81
75 PassRefPtr<RenderStyle> getScrollbarPseudoStyle(ScrollbarPart, PseudoId); 82 PassRefPtr<RenderStyle> getScrollbarPseudoStyle(ScrollbarPart, PseudoId);
76 void updateScrollbarPart(ScrollbarPart, bool destroy = false); 83 void updateScrollbarPart(ScrollbarPart, bool destroy = false);
77 84
85 void destroyParts();
86
78 // This Scrollbar(Widget) may outlive the DOM which created it (during tear down), 87 // This Scrollbar(Widget) may outlive the DOM which created it (during tear down),
79 // so we keep a reference to the Node which caused this custom scrollbar cre ation. 88 // so we keep a reference to the Node which caused this custom scrollbar cre ation.
80 // This will not create a reference cycle as the Widget tree is owned by our containing 89 // This will not create a reference cycle as the Widget tree is owned by our containing
81 // FrameView which this Node pointer can in no way keep alive. See webkit bu g 80610. 90 // FrameView which this Node pointer can in no way keep alive. See webkit bu g 80610.
82 RefPtrWillBePersistent<Node> m_owner; 91 RefPtrWillBeMember<Node> m_owner;
83 92
84 LocalFrame* m_owningFrame; 93 RawPtrWillBeMember<LocalFrame> m_owningFrame;
85 WillBePersistentHeapHashMap<unsigned, RawPtrWillBeMember<RenderScrollbarPart > > m_parts; 94
95 WillBeHeapHashMap<unsigned, RawPtrWillBeMember<RenderScrollbarPart> > m_part s;
96
97 #if ENABLE(OILPAN)
98 // Flag set during finalization to turn off updating of the above heap hash map.
99 bool m_updatePartsMap;
100 #endif
86 }; 101 };
87 102
88 DEFINE_TYPE_CASTS(RenderScrollbar, ScrollbarThemeClient, scrollbar, scrollbar->i sCustomScrollbar(), scrollbar.isCustomScrollbar()); 103 DEFINE_TYPE_CASTS(RenderScrollbar, ScrollbarThemeClient, scrollbar, scrollbar->i sCustomScrollbar(), scrollbar.isCustomScrollbar());
89 104
90 } // namespace blink 105 } // namespace blink
91 106
92 #endif // RenderScrollbar_h 107 #endif // RenderScrollbar_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698