Source/web/WebHelperPluginImpl.h - Issue 603193005: Move the Widget hierarchy to the Oilpan heap.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/web/WebHelperPluginImpl.h

Issue 603193005: Move the Widget hierarchy to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Switch LocalFrame::m_pluginElements rep to HashSet<HTMLPlugInElement*> Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « Source/web/PopupMenuTest.cpp ('k') | Source/web/WebHelperPluginImpl.cpp » ('j') | Source/web/tests/ScrollAnimatorNoneTest.cpp » ('J')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2012 Google Inc. All rights reserved.	2 * Copyright (C) 2012 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 49 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
60 friend class WebHelperPlugin;	60 friend class WebHelperPlugin;

61	61

62 WebHelperPluginImpl();	62 WebHelperPluginImpl();

63 virtual ~WebHelperPluginImpl();	63 virtual ~WebHelperPluginImpl();

64	64

65 bool initialize(const String& pluginType, WebLocalFrameImpl*);	65 bool initialize(const String& pluginType, WebLocalFrameImpl*);

66 void reallyDestroy(Timer<WebHelperPluginImpl>*);	66 void reallyDestroy(Timer<WebHelperPluginImpl>*);

67	67

68 Timer<WebHelperPluginImpl> m_destructionTimer;	68 Timer<WebHelperPluginImpl> m_destructionTimer;

69 RefPtrWillBePersistent<HTMLObjectElement> m_objectElement;	69 RefPtrWillBePersistent<HTMLObjectElement> m_objectElement;

70 RefPtr<WebPluginContainerImpl> m_pluginContainer;	70 RefPtrWillBePersistent<WebPluginContainerImpl> m_pluginContainer;

71 };	71 };

72	72

73 } // namespace blink	73 } // namespace blink

74	74

75 #endif // WebHelperPluginImpl_h	75 #endif // WebHelperPluginImpl_h

OLD	NEW