Source/web/PopupMenuChromium.h - Issue 603193005: Move the Widget hierarchy to the Oilpan heap.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/web/PopupMenuChromium.h

Issue 603193005: Move the Widget hierarchy to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Switch LocalFrame::m_pluginElements rep to HashSet<HTMLPlugInElement*> Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (c) 2008, 2009, Google Inc. All rights reserved.	2 * Copyright (c) 2008, 2009, Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 33 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
44 class PopupMenuChromium final : public PopupMenu {	44 class PopupMenuChromium final : public PopupMenu {

45 public:	45 public:

46 PopupMenuChromium(LocalFrame&, PopupMenuClient*);	46 PopupMenuChromium(LocalFrame&, PopupMenuClient*);

47 virtual ~PopupMenuChromium();	47 virtual ~PopupMenuChromium();

48	48

49 virtual void show(const FloatQuad& controlPosition, const IntSize& controlSi ze, int index) override;	49 virtual void show(const FloatQuad& controlPosition, const IntSize& controlSi ze, int index) override;

50 virtual void hide() override;	50 virtual void hide() override;

51 virtual void updateFromElement() override;	51 virtual void updateFromElement() override;

52 virtual void disconnectClient() override;	52 virtual void disconnectClient() override;

53	53

	54 virtual void trace(Visitor*) OVERRIDE;

	55

54 private:	56 private:

	57 void dispose();

	58

55 PopupMenuClient* m_popupClient;	59 PopupMenuClient* m_popupClient;

56 RefPtr<FrameView> m_frameView;	60 RefPtrWillBeMember<FrameView> m_frameView;

57 RefPtr<PopupContainer> m_popup;	61 RefPtrWillBeMember<PopupContainer> m_popup;

58 };	62 };

59	63

60 } // namespace blink	64 } // namespace blink

61	65

62 #endif	66 #endif

OLD	NEW

« no previous file with comments | « Source/web/PopupListBox.cpp ('k') | Source/web/PopupMenuChromium.cpp » ('j') | Source/web/tests/ScrollAnimatorNoneTest.cpp » ('J')