Source/core/accessibility/AXScrollView.h - Issue 603193005: Move the Widget hierarchy to the Oilpan heap.

Side by Side Diff: Source/core/accessibility/AXScrollView.h

Issue 603193005: Move the Widget hierarchy to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add ~Scrollbar assert Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2011 Apple Inc. All rights reserved.	2 * Copyright (C) 2011 Apple Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 *	7 *

8 * 1. Redistributions of source code must retain the above copyright	8 * 1. Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * 2. Redistributions in binary form must reproduce the above copyright	10 * 2. Redistributions in binary form must reproduce the above copyright

(...skipping 57 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
68 virtual FrameView* documentFrameView() const OVERRIDE;	68 virtual FrameView* documentFrameView() const OVERRIDE;

69 virtual LayoutRect elementRect() const OVERRIDE;	69 virtual LayoutRect elementRect() const OVERRIDE;

70 virtual AXObject* parentObject() const OVERRIDE;	70 virtual AXObject* parentObject() const OVERRIDE;

71 virtual AXObject* parentObjectIfExists() const OVERRIDE;	71 virtual AXObject* parentObjectIfExists() const OVERRIDE;

72	72

73 AXObject* webAreaObject() const;	73 AXObject* webAreaObject() const;

74 virtual AXObject* firstChild() const OVERRIDE { return webAreaObject(); }	74 virtual AXObject* firstChild() const OVERRIDE { return webAreaObject(); }

75 AXScrollbar* addChildScrollbar(Scrollbar*);	75 AXScrollbar* addChildScrollbar(Scrollbar*);

76 void removeChildScrollbar(AXObject*);	76 void removeChildScrollbar(AXObject*);

77	77

	78 // FIXME: Oilpan: Frame/ScrollView is on the heap, but can we

	79 // assume that the corresponding AXScrollView is retired from

	80 // the AX cache before it is finalized? If so, maintaining

	81 // this as a bare pointer appears preferable. A persistent

	82 // could create a leak.
	haraken 2014/09/29 14:16:35 Would you update this comment to clarify that usin Would you update this comment to clarify that using a raw pointer for m_scrollView is fine because m_scrollView is explicitly cleared in AXScrollView::detach() ? sof 2014/10/08 11:52:25 Thanks, clarified. Show quoted text On 2014/09/29 14:16:35, haraken wrote: > > Would you update this comment to clarify that using a raw pointer for > m_scrollView is fine because m_scrollView is explicitly cleared in > AXScrollView::detach() ? > Thanks, clarified.
78 ScrollView* m_scrollView;	83 ScrollView* m_scrollView;

79 RefPtr<AXObject> m_horizontalScrollbar;	84 RefPtr<AXObject> m_horizontalScrollbar;

80 RefPtr<AXObject> m_verticalScrollbar;	85 RefPtr<AXObject> m_verticalScrollbar;

81 bool m_childrenDirty;	86 bool m_childrenDirty;

82 };	87 };

83	88

84 DEFINE_AX_OBJECT_TYPE_CASTS(AXScrollView, isAXScrollView());	89 DEFINE_AX_OBJECT_TYPE_CASTS(AXScrollView, isAXScrollView());

85	90

86 } // namespace blink	91 } // namespace blink

87	92

88 #endif // AXScrollView_h	93 #endif // AXScrollView_h

OLD	NEW

« no previous file with comments | « Source/core/accessibility/AXObjectCache.cpp ('k') | Source/core/accessibility/AXScrollbar.h » ('j') | Source/core/accessibility/AXScrollbar.h » ('J')