Issue 603173003: Revert of Remove unneeded Friend from chrome_metrics_service_accessor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 603173003: Revert of Remove unneeded Friend from chrome_metrics_service_accessor (Closed)

Created:
6 years, 2 months ago by MAD

Modified:
6 years, 2 months ago

Reviewers:
Alexei Svitkine (slow), csharp

CC:
chromium-reviews, Ilya Sherman, asvitkine+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Revert of Remove unneeded Friend from chrome_metrics_service_accessor (patchset #1 id:20001 of https://codereview.chromium.org/601243002/) Reason for revert: We need to bring this back since the usage of it is coming back in an upcoming patch. Sorry about that... BYE MAD Original issue's description: > Remove unneeded Friend from chrome_metrics_service_accessor > > BUG= > > Committed: https://crrev.com/ca032c3aed93e5afd7c32da76147f36a72dc4341 > Cr-Commit-Position: refs/heads/master@{#296722} TBR=asvitkine@chromium.org,csharp@chromium.org NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/6827422878e060296d74e19816bb813a79f91e08 Cr-Commit-Position: refs/heads/master@{#296763}

Created: 6 years, 2 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -0 lines)			Patch
	M	chrome/browser/metrics/chrome_metrics_service_accessor.h	View		2 chunks	+10 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

MAD

Created Revert of Remove unneeded Friend from chrome_metrics_service_accessor

6 years, 2 months ago (2014-09-25 19:22:49 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/603173003/1

6 years, 2 months ago (2014-09-25 19:25:16 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (id:1) as fe4e512a115fda8129a37b714b36dff53f9c0806

6 years, 2 months ago (2014-09-25 19:26:52 UTC) #3

commit-bot: I haz the power

6 years, 2 months ago (2014-09-25 19:28:32 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/6827422878e060296d74e19816bb813a79f91e08
Cr-Commit-Position: refs/heads/master@{#296763}