Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 603083002: Remove foreground tab idle handler (Closed)

Created:
6 years, 2 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove foreground tab idle handler For foreground tabs the blink scheduler handles idle time. BUG=404850, 397026 R=hpayer@chromium.org,sullivan@chromium.org,reveman@chromium.org,ulan@chromium.org,dcheng@chromium.org Committed: https://crrev.com/5a32aaf0592a4109f6d13f39a8aeaa55243fdd26 Cr-Commit-Position: refs/heads/master@{#297025}

Patch Set 1 #

Total comments: 7

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -83 lines) Patch
M content/browser/renderer_host/render_message_filter.h View 1 3 chunks +0 lines, -10 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 1 5 chunks +0 lines, -28 lines 0 comments Download
M content/common/view_messages.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/render_thread_impl.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 3 chunks +7 lines, -39 lines 0 comments Download

Messages

Total messages: 23 (2 generated)
jochen (gone - plz use gerrit)
6 years, 2 months ago (2014-09-25 07:35:26 UTC) #1
jochen (gone - plz use gerrit)
Daniel, please review the removal of the IPC msg Annie, please review everything David, Hannes, ...
6 years, 2 months ago (2014-09-25 07:36:49 UTC) #3
dcheng
content/common/view_messages.h changes and IPC message handler deletions LGTM
6 years, 2 months ago (2014-09-25 07:39:07 UTC) #4
jochen (gone - plz use gerrit)
+ross fyi
6 years, 2 months ago (2014-09-25 11:56:39 UTC) #5
reveman
https://codereview.chromium.org/603083002/diff/1/content/renderer/render_thread_impl.cc File content/renderer/render_thread_impl.cc (left): https://codereview.chromium.org/603083002/diff/1/content/renderer/render_thread_impl.cc#oldcode1077 content/renderer/render_thread_impl.cc:1077: if (!base::DiscardableMemory::ReduceMemoryUsage()) where is this moved?
6 years, 2 months ago (2014-09-25 13:34:17 UTC) #6
jochen (gone - plz use gerrit)
https://codereview.chromium.org/603083002/diff/1/content/renderer/render_thread_impl.cc File content/renderer/render_thread_impl.cc (left): https://codereview.chromium.org/603083002/diff/1/content/renderer/render_thread_impl.cc#oldcode1077 content/renderer/render_thread_impl.cc:1077: if (!base::DiscardableMemory::ReduceMemoryUsage()) On 2014/09/25 at 13:34:17, reveman wrote: > ...
6 years, 2 months ago (2014-09-25 14:18:29 UTC) #7
jochen (gone - plz use gerrit)
On 2014/09/25 at 14:18:29, jochen (slow for reviews) wrote: > https://codereview.chromium.org/603083002/diff/1/content/renderer/render_thread_impl.cc > File content/renderer/render_thread_impl.cc (left): ...
6 years, 2 months ago (2014-09-25 14:34:26 UTC) #8
sullivan
https://codereview.chromium.org/603083002/diff/1/content/browser/renderer_host/render_message_filter.h File content/browser/renderer_host/render_message_filter.h (left): https://codereview.chromium.org/603083002/diff/1/content/browser/renderer_host/render_message_filter.h#oldcode342 content/browser/renderer_host/render_message_filter.h:342: scoped_ptr<base::ProcessMetrics> process_metrics_; Does this affect the PerformanceMonitor.AverageCPU.RendererProcess UMA metric? ...
6 years, 2 months ago (2014-09-25 14:34:47 UTC) #9
reveman
https://codereview.chromium.org/603083002/diff/1/content/renderer/render_thread_impl.cc File content/renderer/render_thread_impl.cc (left): https://codereview.chromium.org/603083002/diff/1/content/renderer/render_thread_impl.cc#oldcode1077 content/renderer/render_thread_impl.cc:1077: if (!base::DiscardableMemory::ReduceMemoryUsage()) On 2014/09/25 14:18:28, jochen (slow for reviews) ...
6 years, 2 months ago (2014-09-25 15:03:41 UTC) #10
jochen (gone - plz use gerrit)
https://codereview.chromium.org/603083002/diff/1/content/browser/renderer_host/render_message_filter.h File content/browser/renderer_host/render_message_filter.h (left): https://codereview.chromium.org/603083002/diff/1/content/browser/renderer_host/render_message_filter.h#oldcode342 content/browser/renderer_host/render_message_filter.h:342: scoped_ptr<base::ProcessMetrics> process_metrics_; On 2014/09/25 at 14:34:47, sullivan wrote: > ...
6 years, 2 months ago (2014-09-25 15:08:36 UTC) #11
sullivan
On 2014/09/25 15:08:36, jochen (slow for reviews) wrote: > https://codereview.chromium.org/603083002/diff/1/content/browser/renderer_host/render_message_filter.h > File content/browser/renderer_host/render_message_filter.h (left): > ...
6 years, 2 months ago (2014-09-25 15:20:56 UTC) #12
sullivan
lgtm
6 years, 2 months ago (2014-09-25 15:21:02 UTC) #13
jochen (gone - plz use gerrit)
On 2014/09/25 at 15:20:56, sullivan wrote: > > > > Is there a test that ...
6 years, 2 months ago (2014-09-25 15:23:28 UTC) #14
reveman
https://codereview.chromium.org/603083002/diff/1/content/renderer/render_thread_impl.cc File content/renderer/render_thread_impl.cc (left): https://codereview.chromium.org/603083002/diff/1/content/renderer/render_thread_impl.cc#oldcode1077 content/renderer/render_thread_impl.cc:1077: if (!base::DiscardableMemory::ReduceMemoryUsage()) On 2014/09/25 15:08:36, jochen (slow for reviews) ...
6 years, 2 months ago (2014-09-25 16:44:49 UTC) #15
rmcilroy
On 2014/09/25 16:44:49, reveman wrote: > https://codereview.chromium.org/603083002/diff/1/content/renderer/render_thread_impl.cc > File content/renderer/render_thread_impl.cc (left): > > https://codereview.chromium.org/603083002/diff/1/content/renderer/render_thread_impl.cc#oldcode1077 > ...
6 years, 2 months ago (2014-09-25 17:45:47 UTC) #16
reveman
On 2014/09/25 17:45:47, rmcilroy wrote: > On 2014/09/25 16:44:49, reveman wrote: > > > https://codereview.chromium.org/603083002/diff/1/content/renderer/render_thread_impl.cc ...
6 years, 2 months ago (2014-09-25 18:42:27 UTC) #17
jochen (gone - plz use gerrit)
here's a version that still calls the reduce memory calls ptal
6 years, 2 months ago (2014-09-26 08:04:31 UTC) #18
reveman
lgtm
6 years, 2 months ago (2014-09-26 18:07:10 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/603083002/20001
6 years, 2 months ago (2014-09-26 18:32:13 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:20001) as a531c805a32ca9ef1cc9679013e7df6e1e6dd90a
6 years, 2 months ago (2014-09-26 20:37:53 UTC) #22
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 20:38:44 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5a32aaf0592a4109f6d13f39a8aeaa55243fdd26
Cr-Commit-Position: refs/heads/master@{#297025}

Powered by Google App Engine
This is Rietveld 408576698