Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Issue 603043002: c++11: Add discussion thread links, ban things that don't work with MSVS. (Closed)

Created:
6 years, 2 months ago by Nico
Modified:
6 years, 2 months ago
Reviewers:
jamesr
CC:
chromium-reviews, Avi (use Gerrit), Peter Kasting
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

c++11: Add discussion thread links, ban things that don't work with MSVS. Namely, ban __func__, constexpr, u"asdf", and char16_t. BUG=none R=jamesr@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/cea20a82a4f0b48ede9543fe4a769ab8e78fb8e2

Patch Set 1 #

Patch Set 2 : contexpr #

Total comments: 2

Patch Set 3 : . #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -65 lines) Patch
M styleguide/c++/c++11.html View 1 2 18 chunks +62 lines, -65 lines 1 comment Download

Messages

Total messages: 9 (1 generated)
Nico
6 years, 2 months ago (2014-09-25 01:59:23 UTC) #2
Avi (use Gerrit)
https://codereview.chromium.org/603043002/diff/20001/styleguide/c++/c++11.html File styleguide/c++/c++11.html (right): https://codereview.chromium.org/603043002/diff/20001/styleguide/c++/c++11.html#newcode124 styleguide/c++/c++11.html:124: <p>This section will lists C++11 features that are not ...
6 years, 2 months ago (2014-09-25 04:11:49 UTC) #3
Nico
https://codereview.chromium.org/603043002/diff/20001/styleguide/c++/c++11.html File styleguide/c++/c++11.html (right): https://codereview.chromium.org/603043002/diff/20001/styleguide/c++/c++11.html#newcode124 styleguide/c++/c++11.html:124: <p>This section will lists C++11 features that are not ...
6 years, 2 months ago (2014-09-25 04:13:15 UTC) #4
jamesr
On 2014/09/25 04:13:15, Nico (hiding) wrote: > https://codereview.chromium.org/603043002/diff/20001/styleguide/c++/c++11.html > File styleguide/c++/c++11.html (right): > > https://codereview.chromium.org/603043002/diff/20001/styleguide/c++/c++11.html#newcode124 ...
6 years, 2 months ago (2014-09-25 06:00:21 UTC) #5
jamesr
lgtm https://codereview.chromium.org/603043002/diff/40001/styleguide/c++/c++11.html File styleguide/c++/c++11.html (right): https://codereview.chromium.org/603043002/diff/40001/styleguide/c++/c++11.html#newcode143 styleguide/c++/c++11.html:143: <td>TODO: documentation link</td> could we link to a ...
6 years, 2 months ago (2014-09-25 06:01:52 UTC) #6
Nico
No hablo espanol. Yo soy un pollo. On Sep 24, 2014 11:00 PM, <jamesr@chromium.org> wrote: ...
6 years, 2 months ago (2014-09-25 06:02:13 UTC) #7
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/cea20a82a4f0b48ede9543fe4a769ab8e78fb8e2 Cr-Commit-Position: refs/heads/master@{#296739}
6 years, 2 months ago (2014-09-25 17:48:32 UTC) #8
Nico
6 years, 2 months ago (2014-09-25 17:48:35 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as cea20a8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698