Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 603033002: Get FileSelect dialog work on athena (Closed)

Created:
6 years, 3 months ago by oshima
Modified:
6 years, 3 months ago
Reviewers:
Jun Mukai, sky
CC:
chromium-reviews, dbeam+watch-options_chromium.org, extensions-reviews_chromium.org, tfarina, jam, darin-cc_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Get FileSelect dialog work on athena Introduced c/b/ui/views/athena/athena_util so that arbitrary code under chrome/browser doesn't have to depend on athena/ BUG=414340, 410499 Committed: https://crrev.com/b79e7fadbdb6fd5dba5049dda6aeb0863a44d18a Cr-Commit-Position: refs/heads/master@{#296628}

Patch Set 1 : #

Total comments: 4

Patch Set 2 : reformat #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -33 lines) Patch
M athena/activity/activity_manager_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M athena/activity/activity_manager_impl.cc View 2 chunks +16 lines, -15 lines 0 comments Download
M athena/activity/activity_manager_unittest.cc View 3 chunks +24 lines, -4 lines 0 comments Download
M athena/activity/public/activity.h View 2 chunks +8 lines, -0 lines 0 comments Download
M athena/activity/public/activity_manager.h View 2 chunks +8 lines, -0 lines 0 comments Download
M athena/content/app_activity.h View 1 chunk +1 line, -0 lines 0 comments Download
M athena/content/app_activity.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M athena/content/app_activity_proxy.h View 1 chunk +1 line, -0 lines 0 comments Download
M athena/content/app_activity_proxy.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M athena/content/web_activity.h View 1 chunk +1 line, -0 lines 0 comments Download
M athena/content/web_activity.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M athena/test/sample_activity.h View 1 chunk +1 line, -0 lines 0 comments Download
M athena/test/sample_activity.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/athena/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/athena/athena_util.h View 1 1 chunk +19 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/athena/athena_util.cc View 1 1 chunk +22 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/athena/chrome_browser_main_extra_parts_athena.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/select_file_dialog_extension.cc View 1 5 chunks +20 lines, -12 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
oshima
mukai -> everything sky -> chrome/browser/ui/views
6 years, 3 months ago (2014-09-24 23:52:42 UTC) #6
sky
LGTM https://codereview.chromium.org/603033002/diff/60001/chrome/browser/ui/views/athena/DEPS File chrome/browser/ui/views/athena/DEPS (right): https://codereview.chromium.org/603033002/diff/60001/chrome/browser/ui/views/athena/DEPS#newcode2 chrome/browser/ui/views/athena/DEPS:2: "+athena/activity/public", I'm sad to see this list growing.
6 years, 3 months ago (2014-09-24 23:57:09 UTC) #7
Jun Mukai
lgtm https://codereview.chromium.org/603033002/diff/60001/chrome/browser/ui/views/athena/athena_util.cc File chrome/browser/ui/views/athena/athena_util.cc (right): https://codereview.chromium.org/603033002/diff/60001/chrome/browser/ui/views/athena/athena_util.cc#newcode13 chrome/browser/ui/views/athena/athena_util.cc:13: aura::Window* owner_window) { Doesn't this fit into the ...
6 years, 3 months ago (2014-09-25 00:24:05 UTC) #8
oshima
https://codereview.chromium.org/603033002/diff/60001/chrome/browser/ui/views/athena/athena_util.cc File chrome/browser/ui/views/athena/athena_util.cc (right): https://codereview.chromium.org/603033002/diff/60001/chrome/browser/ui/views/athena/athena_util.cc#newcode13 chrome/browser/ui/views/athena/athena_util.cc:13: aura::Window* owner_window) { On 2014/09/25 00:24:05, Jun Mukai wrote: ...
6 years, 3 months ago (2014-09-25 00:36:07 UTC) #9
oshima
https://codereview.chromium.org/603033002/diff/60001/chrome/browser/ui/views/athena/DEPS File chrome/browser/ui/views/athena/DEPS (right): https://codereview.chromium.org/603033002/diff/60001/chrome/browser/ui/views/athena/DEPS#newcode2 chrome/browser/ui/views/athena/DEPS:2: "+athena/activity/public", On 2014/09/24 23:57:09, sky wrote: > I'm sad ...
6 years, 3 months ago (2014-09-25 00:36:52 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/603033002/80001
6 years, 3 months ago (2014-09-25 00:40:27 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:80001) as 3218004aa12ee7a1536b725423a9f60ec65d234e
6 years, 3 months ago (2014-09-25 02:15:47 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-25 02:16:23 UTC) #14
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/b79e7fadbdb6fd5dba5049dda6aeb0863a44d18a
Cr-Commit-Position: refs/heads/master@{#296628}

Powered by Google App Engine
This is Rietveld 408576698