Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(769)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 602963002: Use only one tester for debug Linux since we're swarming the tests now. (Closed)

Created:
6 years, 2 months ago by jam
Modified:
6 years, 2 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, pgervais+watch_chromium.org, kjellander-cc_chromium.org, cmp-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Project:
tools
Visibility:
Public.

Description

Use only one tester for debug Linux since we're swarming the tests now. BUG=414808

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -409 lines) Patch
M masters/master.chromium.linux/master_linux_cfg.py View 2 chunks +2 lines, -4 lines 0 comments Download
M masters/master.chromium.linux/slaves.cfg View 1 chunk +1 line, -9 lines 2 comments Download
M scripts/slave/recipe_modules/chromium/chromium_linux.py View 3 chunks +2 lines, -20 lines 0 comments Download
D scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Tests__dbg__1_.json View 1 chunk +0 lines, -217 lines 0 comments Download
D scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Tests__dbg__2_.json View 1 chunk +0 lines, -159 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
jam
This depends on https://codereview.chromium.org/599993003/ landing first https://codereview.chromium.org/602963002/diff/1/masters/master.chromium.linux/slaves.cfg File masters/master.chromium.linux/slaves.cfg (left): https://codereview.chromium.org/602963002/diff/1/masters/master.chromium.linux/slaves.cfg#oldcode73 masters/master.chromium.linux/slaves.cfg:73: 'hostname': 'vm917-m1', I ...
6 years, 2 months ago (2014-09-24 21:41:36 UTC) #2
Paweł Hajdan Jr.
LGTM https://codereview.chromium.org/602963002/diff/1/masters/master.chromium.linux/slaves.cfg File masters/master.chromium.linux/slaves.cfg (left): https://codereview.chromium.org/602963002/diff/1/masters/master.chromium.linux/slaves.cfg#oldcode73 masters/master.chromium.linux/slaves.cfg:73: 'hostname': 'vm917-m1', On 2014/09/24 21:41:36, jam wrote: > ...
6 years, 2 months ago (2014-09-24 22:20:01 UTC) #3
jam
6 years, 2 months ago (2014-09-29 05:34:02 UTC) #4 
given the complicated restart requirements since some of these changes require a
master restart, while others take effect right now, i will do something simpler:
I will move all tests to the 1st tester of every config. then in a separate
patch i'll make the change to remove all the other testers. then we'll just be
left with a tester called "1" for every config. if anyone wants to clean that
later to remove "1", that's fine

Powered by Google App Engine
This is Rietveld 408576698