Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 602953002: Blacklist some samsung devices from MSE support (Closed)

Created:
6 years, 3 months ago by qinmin
Modified:
6 years, 3 months ago
Reviewers:
xhwang
CC:
chromium-reviews, feature-media-reviews_chromium.org, avayvod+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Blacklist some samsung devices from MSE support Lots of crash reports from SGS devices running JB, mostly galaxy S3 A driver bug is filed against samsung BUG=365494 Committed: https://crrev.com/017b9dbc43c2051d6f892dfddb0d2c3894ddf634 Cr-Commit-Position: refs/heads/master@{#296572}

Patch Set 1 #

Total comments: 2

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M media/base/android/media_codec_bridge.cc View 1 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
qinmin
PTAL
6 years, 3 months ago (2014-09-24 21:38:46 UTC) #2
xhwang
lgtm % nit https://codereview.chromium.org/602953002/diff/1/media/base/android/media_codec_bridge.cc File media/base/android/media_codec_bridge.cc (right): https://codereview.chromium.org/602953002/diff/1/media/base/android/media_codec_bridge.cc#newcode113 media/base/android/media_codec_bridge.cc:113: } Provide comments and link to ...
6 years, 3 months ago (2014-09-24 22:23:16 UTC) #3
qinmin
https://codereview.chromium.org/602953002/diff/1/media/base/android/media_codec_bridge.cc File media/base/android/media_codec_bridge.cc (right): https://codereview.chromium.org/602953002/diff/1/media/base/android/media_codec_bridge.cc#newcode113 media/base/android/media_codec_bridge.cc:113: } On 2014/09/24 22:23:16, xhwang wrote: > Provide comments ...
6 years, 3 months ago (2014-09-24 22:49:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/602953002/20001
6 years, 3 months ago (2014-09-24 22:51:24 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 4059d37ad389e877672d44f9c95ef3a8358b43f5
6 years, 3 months ago (2014-09-24 23:45:15 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 23:47:22 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/017b9dbc43c2051d6f892dfddb0d2c3894ddf634
Cr-Commit-Position: refs/heads/master@{#296572}

Powered by Google App Engine
This is Rietveld 408576698