Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Issue 60293002: Update breakpad to r1230 (Closed)

Created:
7 years, 1 month ago by Mark Mentovai
Modified:
7 years, 1 month ago
Reviewers:
hans, Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Update breakpad to r1230, picking up: r1230 (mac sender) NSLocalizedString compatibility (10.8 SDK and clang trunk -Wformat-extra-args). r1229 (processor) map_serializers_unittest: fix unused variable warning. r1228 (linux symupload) Print response code when sym_upload fails. r1227 (processor) Add some symbols missing from last commit. r1226 (processor) Add simple exploitability analysis for Linux crashes. r1225 (common) Switch to scoped_array instead of inappropriate scoped_ptr. r1224 (linux handler) Increase exception handler stack size for dumping thread. r1223 (mac handler) Remove define of mach_vm_region from mach_vm_compatibility.h. BUG=314109 R=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233059

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M breakpad/breakpad.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mark Mentovai
7 years, 1 month ago (2013-11-05 17:03:13 UTC) #1
Nico
Lgtm On Nov 5, 2013 9:03 AM, <mark@chromium.org> wrote: > Reviewers: Nico, hans, > > ...
7 years, 1 month ago (2013-11-05 17:15:35 UTC) #2
Mark Mentovai
7 years, 1 month ago (2013-11-05 19:40:56 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r233059 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698