Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1209)

Issue 602873002: Prevent orthogonal fling accumulation (Closed)

Created:
6 years, 2 months ago by jdduke (slow)
Modified:
6 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jdduke+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Prevent orthogonal fling accumulation Tighten the directional comparison for fling accumulation, preventing perfectly orthogonal flings from accumulating. Also adjust Android's ContentViewScrollingTest#testFling integration test to scale the fling by the device scale factor, ensuring consistent results all all displays. BUG=406848 Committed: https://crrev.com/1b241325584a8612ff035c809ecfdeefa08063c5 Cr-Commit-Position: refs/heads/master@{#296507}

Patch Set 1 : Cleanup #

Patch Set 2 : More cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -8 lines) Patch
M content/public/android/javatests/src/org/chromium/content/browser/ContentViewScrollingTest.java View 2 chunks +12 lines, -6 lines 0 comments Download
M content/renderer/input/input_handler_proxy.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M content/renderer/input/input_handler_proxy_unittest.cc View 1 1 chunk +42 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
jdduke (slow)
aelias@: PTAL, thanks.
6 years, 2 months ago (2014-09-24 19:09:21 UTC) #5
aelias_OOO_until_Jul13
lgtm except, <= is nonstrict inequality so your patch description seems misleading.
6 years, 2 months ago (2014-09-24 19:21:53 UTC) #6
jdduke (slow)
On 2014/09/24 19:21:53, aelias wrote: > lgtm except, <= is nonstrict inequality so your patch ...
6 years, 2 months ago (2014-09-24 19:23:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/602873002/80001
6 years, 2 months ago (2014-09-24 19:25:31 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:80001) as 08bd397beeabad0dbcd276a920466fa4af4f871b
6 years, 2 months ago (2014-09-24 20:24:59 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-09-24 20:25:33 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1b241325584a8612ff035c809ecfdeefa08063c5
Cr-Commit-Position: refs/heads/master@{#296507}

Powered by Google App Engine
This is Rietveld 408576698