Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1227)

Unified Diff: runtime/vm/object.cc

Issue 602853002: Allow setting breakpoints specifying the suffix of a file path (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/debugger.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object.cc
===================================================================
--- runtime/vm/object.cc (revision 40734)
+++ runtime/vm/object.cc (working copy)
@@ -9115,12 +9115,22 @@
const Array& scripts = Array::Handle(LoadedScripts());
Script& script = Script::Handle();
String& script_url = String::Handle();
- intptr_t num_scripts = scripts.Length();
+ const intptr_t url_length = url.Length();
+ const intptr_t num_scripts = scripts.Length();
for (int i = 0; i < num_scripts; i++) {
script ^= scripts.At(i);
script_url = script.url();
- if (script_url.Equals(url)) {
+ const intptr_t start_idx = script_url.Length() - url_length;
+ if ((start_idx == 0) && url.Equals(script_url)) {
return script.raw();
+ } else if (start_idx > 0) {
+ // If we do a suffix match, only match if the partial path
+ // starts at or immediately after the path separator.
+ if (((url.CharAt(0) == '/') ||
+ (script_url.CharAt(start_idx - 1) == '/')) &&
+ url.Equals(script_url, start_idx, url_length)) {
+ return script.raw();
+ }
}
}
return Script::null();
« no previous file with comments | « runtime/vm/debugger.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698