Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 602843002: Don't add the app activity as it's already added. (Closed)

Created:
6 years, 3 months ago by oshima
Modified:
6 years, 3 months ago
Reviewers:
Jun Mukai
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src@master
Project:
chromium
Visibility:
Public.

Description

Don't add the app activity as it's already added. Looks like I made an error when I split the CL. I'll add a test in a separate CL. BUG=None TBR=mukai@chromium.org Committed: https://crrev.com/0b0be35de4832c5aebda4a084baa6be20ba9f17f Cr-Commit-Position: refs/heads/master@{#296491}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M athena/extensions/athena_app_window_client_base.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
oshima
tbr'ing as it's causing crash. I'll work in a test in a separate CL.
6 years, 3 months ago (2014-09-24 18:53:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/602843002/1
6 years, 3 months ago (2014-09-24 18:54:44 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as 2da725a544d54a727ea9cbdc9934a13f167762c7
6 years, 3 months ago (2014-09-24 19:36:26 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0b0be35de4832c5aebda4a084baa6be20ba9f17f Cr-Commit-Position: refs/heads/master@{#296491}
6 years, 3 months ago (2014-09-24 19:37:13 UTC) #6
Jun Mukai
6 years, 3 months ago (2014-09-24 20:44:58 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698