Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Issue 602823002: Re-land r296395: "Instrumented libraries: update the libnspr4 build script." (Closed)

Created:
6 years, 2 months ago by earthdok
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Re-land r296395: "Instrumented libraries: update the libnspr4 build script." There has been a security update in gPrecise which changed the paths somewhat. The previous version of this CL was reverted as it broke on vanilla Precise. This version fixes that. BUG=313751 TBR=glider@chromium.org NOTRY=true Committed: https://crrev.com/e28696420fcac7596c9262868b93f16c1231e0ea Cr-Commit-Position: refs/heads/master@{#296466}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M third_party/instrumented_libraries/scripts/libnspr4.sh View 1 chunk +10 lines, -1 line 1 comment Download

Messages

Total messages: 6 (1 generated)
earthdok
6 years, 2 months ago (2014-09-24 18:11:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/602823002/1
6 years, 2 months ago (2014-09-24 18:11:35 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as 8d01a12d944451eaa3be12b62a60a3402b28d4aa
6 years, 2 months ago (2014-09-24 18:12:08 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e28696420fcac7596c9262868b93f16c1231e0ea Cr-Commit-Position: refs/heads/master@{#296466}
6 years, 2 months ago (2014-09-24 18:12:40 UTC) #5
Alexander Potapenko
6 years, 2 months ago (2014-09-25 08:14:37 UTC) #6
Message was sent while issue was closed.
lgtm

https://codereview.chromium.org/602823002/diff/1/third_party/instrumented_lib...
File third_party/instrumented_libraries/scripts/libnspr4.sh (right):

https://codereview.chromium.org/602823002/diff/1/third_party/instrumented_lib...
third_party/instrumented_libraries/scripts/libnspr4.sh:15: echo "libnspr4.sh:
package has unexpected directory structure. Please update this script."
I'd prefer a line wrap here.

Powered by Google App Engine
This is Rietveld 408576698