src/ic/handler-compiler.cc - Issue 602773003: Eliminate special keyed load string stub in favor of uniform handlers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic/handler-compiler.cc

Issue 602773003: Eliminate special keyed load string stub in favor of uniform handlers. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: REBASE and ports. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ic/handler-compiler.cc

diff --git a/src/ic/handler-compiler.cc b/src/ic/handler-compiler.cc

index 6180b5f6f18becb3d525dd781b76c4ee152673a8..7f440c07ca0e4de42d2000148a3cef236bfaa847 100644

--- a/src/ic/handler-compiler.cc

+++ b/src/ic/handler-compiler.cc

@@ -415,8 +415,8 @@ void ElementHandlerCompiler::CompileElementHandlers(

Handle<Map> receiver_map = receiver_maps->at(i);

Handle<Code> cached_stub;

- if ((receiver_map->instance_type() & kNotStringTag) == 0) {

- cached_stub = isolate()->builtins()->KeyedLoadIC_String();

+ if (receiver_map->IsStringMap()) {

+ cached_stub = LoadIndexedStringStub(isolate()).GetCode();

} else if (receiver_map->instance_type() < FIRST_JS_RECEIVER_TYPE) {

cached_stub = isolate()->builtins()->KeyedLoadIC_Slow();

} else {

« no previous file with comments | « src/ic/arm64/ic-arm64.cc ('k') | src/ic/ia32/ic-ia32.cc » ('j') | no next file with comments »