Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(750)

Unified Diff: components/signin/core/browser/about_signin_internals.h

Issue 602773002: Handle multiple signin_internal_uis by using a linked_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unneeded headers Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/signin/core/browser/about_signin_internals.h
diff --git a/components/signin/core/browser/about_signin_internals.h b/components/signin/core/browser/about_signin_internals.h
index f3458219fa0f40210268a67eaa9d95ffa3403a89..0a348d676c754c9a115a35bd94a85db643fedf9c 100644
--- a/components/signin/core/browser/about_signin_internals.h
+++ b/components/signin/core/browser/about_signin_internals.h
@@ -8,6 +8,7 @@
#include <map>
#include <string>
+#include "base/memory/linked_ptr.h"
#include "base/memory/scoped_ptr.h"
#include "base/observer_list.h"
#include "base/values.h"
@@ -39,12 +40,10 @@ class AboutSigninInternals
public:
// |info| will contain the dictionary of signin_status_ values as indicated
// in the comments for GetSigninStatus() below.
- virtual void OnSigninStateChanged(
- scoped_ptr<base::DictionaryValue> info) = 0;
+ virtual void OnSigninStateChanged(const base::DictionaryValue* info) = 0;
// Notification that the cookie accounts are ready to be displayed.
- virtual void OnCookieAccountsFetched(
- scoped_ptr<base::DictionaryValue> info) = 0;
+ virtual void OnCookieAccountsFetched(const base::DictionaryValue* info) = 0;
};
AboutSigninInternals(ProfileOAuth2TokenService* token_service,
« no previous file with comments | « chrome/browser/ui/webui/signin_internals_ui.cc ('k') | components/signin/core/browser/about_signin_internals.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698