QUIC - Used Quic and IP Address in prefs persistent store. It is

QUIC - Persist if we have used Quic (and IP Address of local
machine) in prefs persistent store.

It is temporarily saved under kDummyHostname
(quic.global.props). Will change the code to save it in
globals in the next CL.

R=rch@chromium.org

Committed: https://crrev.com/fc47e0e9879eaac0d121274eaa6b3b0e58ae0a1f
Cr-Commit-Position: refs/heads/master@{#296867}

[ramant (doing other things), 2014-09-25 20:38:37]

Patchset #1 (id:1) has been deleted

[ramant (doing other things), 2014-09-25 20:38:43]

Patchset #1 (id:20001) has been deleted

[ramant (doing other things), 2014-09-25 20:42:02]

Patchset #1 (id:40001) has been deleted

[ramant (doing other things), 2014-09-25 20:43:20]

Patchset #1 (id:60001) has been deleted

[ramant (doing other things), 2014-09-25 20:48:37]

Hi Ryan,
  Persisted used_quic and initialized require_confirmation_ with the value
persisted. As you had mentioned, this could
potentially save 1 RTT.

The following is the data that is saved.

            "quic.global.props:0": {
               "supports_quic": {
                  "address": "x.x.x.x:y",
                  "used_quic": true
               }

thanks
raman
            },

[Ryan Hamilton, 2014-09-25 20:59:42]

https://codereview.chromium.org/602763004/diff/80001/net/quic/quic_stream_fac...
File net/quic/quic_stream_factory.cc (right):

https://codereview.chromium.org/602763004/diff/80001/net/quic/quic_stream_fac...
net/quic/quic_stream_factory.cc:535: require_confirmation_ = false;
This does not appear to be using the IP address. Did you mean to check it here?

[ramant (doing other things), 2014-09-26 00:04:05]

Hi Ryan,
  As we had talked offline, implemented checking of ip address and used_quic
before setting require_confirmation_ to false in CreateSession. PTAL.

thanks
raman

https://codereview.chromium.org/602763004/diff/80001/net/quic/quic_stream_fac...
File net/quic/quic_stream_factory.cc (right):

https://codereview.chromium.org/602763004/diff/80001/net/quic/quic_stream_fac...
net/quic/quic_stream_factory.cc:535: require_confirmation_ = false;
On 2014/09/25 20:59:42, Ryan Hamilton wrote:
> This does not appear to be using the IP address. Did you mean to check it
here?

Done.

[Ryan Hamilton, 2014-09-26 00:06:58]

lgtm

[ramant (doing other things), 2014-09-26 00:07:20]

The CQ bit was checked by rtenneti@chromium.org

[commit-bot: I haz the power, 2014-09-26 00:08:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/602763004/100001

[commit-bot: I haz the power, 2014-09-26 01:26:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-26 01:26:47]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[ramant (doing other things), 2014-09-26 01:41:15]

The CQ bit was checked by rtenneti@chromium.org

[commit-bot: I haz the power, 2014-09-26 01:42:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/602763004/120001

[commit-bot: I haz the power, 2014-09-26 02:54:12]

Committed patchset #3 (id:120001) as b7403c38555378fb4d1722488d216a0649503698

[commit-bot: I haz the power, 2014-09-26 02:54:47]

Patchset 3 (id:??) landed as
https://crrev.com/fc47e0e9879eaac0d121274eaa6b3b0e58ae0a1f
Cr-Commit-Position: refs/heads/master@{#296867}