Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 602713002: Add tests for representation change of constants. (Closed)

Created:
6 years, 3 months ago by titzer
Modified:
6 years, 3 months ago
Reviewers:
Jarin
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Add tests for representation change of constants. R=jarin@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=24191

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+241 lines, -41 lines) Patch
M test/cctest/compiler/test-representation-change.cc View 1 5 chunks +241 lines, -41 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
titzer
6 years, 3 months ago (2014-09-24 14:47:35 UTC) #1
Jarin
https://codereview.chromium.org/602713002/diff/1/test/cctest/compiler/test-representation-change.cc File test/cctest/compiler/test-representation-change.cc (right): https://codereview.chromium.org/602713002/diff/1/test/cctest/compiler/test-representation-change.cc#newcode342 test/cctest/compiler/test-representation-change.cc:342: r.CheckInt32Constant(c, *i); Should not this (+ the guys below) ...
6 years, 3 months ago (2014-09-24 15:11:22 UTC) #2
titzer
https://codereview.chromium.org/602713002/diff/1/test/cctest/compiler/test-representation-change.cc File test/cctest/compiler/test-representation-change.cc (right): https://codereview.chromium.org/602713002/diff/1/test/cctest/compiler/test-representation-change.cc#newcode342 test/cctest/compiler/test-representation-change.cc:342: r.CheckInt32Constant(c, *i); On 2014/09/24 15:11:21, jarin wrote: > Should ...
6 years, 3 months ago (2014-09-24 15:53:09 UTC) #3
Jarin
lgtm
6 years, 3 months ago (2014-09-24 16:02:32 UTC) #4
titzer
6 years, 3 months ago (2014-09-24 16:04:16 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 manually as 24191 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698