Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 602633002: Make device=None default argument of CrosPlatformBackend (Closed)

Created:
6 years, 3 months ago by nednguyen
Modified:
6 years, 3 months ago
Reviewers:
achuithb
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make device=None default argument of CrosPlatformBackend TEST=None NOTRY=True TBR=achuith@chromium.org BUG=417224 Committed: https://crrev.com/a27f5031142217fb36b5d4f34dd155e31ecb4c5b Cr-Commit-Position: refs/heads/master@{#296401}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/telemetry/telemetry/core/platform/cros_platform_backend.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/602633002/1
6 years, 3 months ago (2014-09-24 12:59:49 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as fc23bcefc17bf127fc68312deaf69d5c606d0e06
6 years, 3 months ago (2014-09-24 13:00:05 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a27f5031142217fb36b5d4f34dd155e31ecb4c5b Cr-Commit-Position: refs/heads/master@{#296401}
6 years, 3 months ago (2014-09-24 13:00:43 UTC) #4
achuithb
6 years, 3 months ago (2014-09-24 13:01:46 UTC) #5
Message was sent while issue was closed.
lgtm. Thanks!

Powered by Google App Engine
This is Rietveld 408576698