Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Issue 602613002: Add some tests about range types. (Closed)

Created:
6 years, 3 months ago by neis
Modified:
6 years, 3 months ago
Reviewers:
rossberg
Project:
v8
Visibility:
Public.

Description

Add some tests about range types. Add missing tests for context types. Rearrange some other tests. Make printing of constant types more useful. Give counter-examples for properties that no longer hold. R=rossberg@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=24212

Patch Set 1 #

Total comments: 7

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+214 lines, -54 lines) Patch
M src/types.cc View 1 chunk +1 line, -2 lines 0 comments Download
M test/cctest/test-types.cc View 1 22 chunks +213 lines, -52 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
neis
6 years, 3 months ago (2014-09-24 11:57:55 UTC) #1
neis1
https://codereview.chromium.org/602613002/diff/1/test/cctest/test-types.cc File test/cctest/test-types.cc (left): https://codereview.chromium.org/602613002/diff/1/test/cctest/test-types.cc#oldcode1779 test/cctest/test-types.cc:1779: */ I'm not sure why I thought this wouldn't ...
6 years, 3 months ago (2014-09-24 12:01:01 UTC) #2
rossberg
https://codereview.chromium.org/602613002/diff/1/test/cctest/test-types.cc File test/cctest/test-types.cc (right): https://codereview.chromium.org/602613002/diff/1/test/cctest/test-types.cc#newcode520 test/cctest/test-types.cc:520: // Subtyping: Class(M1)->Is(Class(M2)) iff M1 = M2 Hm, I'd ...
6 years, 3 months ago (2014-09-24 12:59:09 UTC) #3
neis1
https://codereview.chromium.org/602613002/diff/1/test/cctest/test-types.cc File test/cctest/test-types.cc (right): https://codereview.chromium.org/602613002/diff/1/test/cctest/test-types.cc#newcode520 test/cctest/test-types.cc:520: // Subtyping: Class(M1)->Is(Class(M2)) iff M1 = M2 On 2014/09/24 ...
6 years, 3 months ago (2014-09-24 15:12:08 UTC) #4
rossberg
lgtm
6 years, 3 months ago (2014-09-24 17:26:46 UTC) #5
neis
6 years, 3 months ago (2014-09-25 08:31:32 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 24212 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698