Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 602603003: Revert of Adding split view divider widget. (Closed)

Created:
6 years, 2 months ago by Nico
Modified:
6 years, 2 months ago
CC:
chromium-reviews, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Adding split view divider widget. (patchset #15 id:280001 of https://codereview.chromium.org/545393002/) Reason for revert: DragHandleTest.ScrollTest is failing on the bots: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%283%29/builds/36880 Original issue's description: > Adding split view divider widget. > > Adding split view divider widget which could be dragged to exit the split view. > > BUG=403207, 408691 > > Committed: https://crrev.com/b47c16517f0882cbabf8c9aa9ce66711f026fd5b > Cr-Commit-Position: refs/heads/master@{#296351} TBR=mukai@chromium.org,oshima@chromium.org,sadrul@chromium.org,tdanderson@chromium.org,pkotwicz@chromium.org,mfomitchev@chromium.org NOTREECHECKS=true NOTRY=true BUG=403207, 408691 Committed: https://crrev.com/f1546bfaabc3492485219dfb51a270bae8da41b9 Cr-Commit-Position: refs/heads/master@{#296433}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -762 lines) Patch
M athena/athena.gyp View 4 chunks +6 lines, -9 lines 0 comments Download
M athena/util/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
D athena/util/drag_handle.h View 1 chunk +0 lines, -41 lines 0 comments Download
D athena/util/drag_handle.cc View 1 chunk +0 lines, -142 lines 0 comments Download
D athena/util/drag_handle_unittest.cc View 1 chunk +0 lines, -138 lines 0 comments Download
M athena/wm/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M athena/wm/bezel_controller.h View 2 chunks +8 lines, -4 lines 0 comments Download
M athena/wm/bezel_controller.cc View 4 chunks +23 lines, -37 lines 0 comments Download
M athena/wm/split_view_controller.h View 6 chunks +16 lines, -63 lines 0 comments Download
M athena/wm/split_view_controller.cc View 10 chunks +59 lines, -322 lines 0 comments Download
M athena/wm/window_manager_impl.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M athena/wm/window_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
Created Revert of Adding split view divider widget.
6 years, 2 months ago (2014-09-24 16:19:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/602603003/1
6 years, 2 months ago (2014-09-24 16:20:55 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 4c6c097400bca8fa7018e3431560e478d16ea1eb
6 years, 2 months ago (2014-09-24 16:21:21 UTC) #3
commit-bot: I haz the power
6 years, 2 months ago (2014-09-24 16:22:05 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f1546bfaabc3492485219dfb51a270bae8da41b9
Cr-Commit-Position: refs/heads/master@{#296433}

Powered by Google App Engine
This is Rietveld 408576698