Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 602593004: Chromecast: disables downloads from the Chromecast shell. (Closed)

Created:
6 years, 2 months ago by gunsch
Modified:
6 years, 2 months ago
Reviewers:
lcwu1
CC:
chromium-reviews, lcwu+watch_chromium.org, maclellant1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Chromecast: disables downloads from the Chromecast shell. R=lcwu@chromium.org BUG=336640 Committed: https://crrev.com/a88fa8557f96858506a77ebbdddd5e375a2d0c16 Cr-Commit-Position: refs/heads/master@{#296615}

Patch Set 1 #

Total comments: 2

Patch Set 2 : formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -3 lines) Patch
M chromecast/chromecast.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M chromecast/shell/browser/cast_browser_context.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chromecast/shell/browser/cast_browser_context.cc View 3 chunks +4 lines, -3 lines 0 comments Download
A chromecast/shell/browser/cast_download_manager_delegate.h View 1 1 chunk +41 lines, -0 lines 0 comments Download
A chromecast/shell/browser/cast_download_manager_delegate.cc View 1 chunk +58 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
gunsch
6 years, 2 months ago (2014-09-24 19:21:34 UTC) #1
lcwu1
LGTM after fixing a couple of format issues. https://codereview.chromium.org/602593004/diff/1/chromecast/shell/browser/cast_download_manager_delegate.h File chromecast/shell/browser/cast_download_manager_delegate.h (right): https://codereview.chromium.org/602593004/diff/1/chromecast/shell/browser/cast_download_manager_delegate.h#newcode19 chromecast/shell/browser/cast_download_manager_delegate.h:19: virtual ...
6 years, 2 months ago (2014-09-24 23:57:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/602593004/20001
6 years, 2 months ago (2014-09-25 00:08:30 UTC) #4
gunsch
https://codereview.chromium.org/602593004/diff/1/chromecast/shell/browser/cast_download_manager_delegate.h File chromecast/shell/browser/cast_download_manager_delegate.h (right): https://codereview.chromium.org/602593004/diff/1/chromecast/shell/browser/cast_download_manager_delegate.h#newcode19 chromecast/shell/browser/cast_download_manager_delegate.h:19: virtual void GetNextId( On 2014/09/24 23:57:27, lcwu1 wrote: > ...
6 years, 2 months ago (2014-09-25 00:12:38 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as f3547a7ce7ce267e33ea99957b371941ef7e4903
6 years, 2 months ago (2014-09-25 01:46:49 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-25 01:47:23 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/a88fa8557f96858506a77ebbdddd5e375a2d0c16
Cr-Commit-Position: refs/heads/master@{#296615}

Powered by Google App Engine
This is Rietveld 408576698