Issue 602563003: Fixing script injection in app_shell.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 602563003: Fixing script injection in app_shell. (Closed)

Created:
6 years, 2 months ago by lfg

Modified:
6 years, 2 months ago

Reviewers:
Ken Rockot(use gerrit already)

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, Xi Han, Fady Samuel, wjmaclean

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fixing script injection in app_shell. Script injection wasn't working in app_shell because the ScriptInjectionManager never got created. BUG=352293 Committed: https://crrev.com/497416b6baae8a66fa850aa80f96c1005d7e28e7 Cr-Commit-Position: refs/heads/master@{#296679}

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	extensions/shell/renderer/shell_content_renderer_client.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/602563003/1

6 years, 2 months ago (2014-09-25 06:37:02 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as ef3d2285ce5d0e7e45cdd306ff09ffad2feaaba9

6 years, 2 months ago (2014-09-25 08:18:04 UTC) #6

commit-bot: I haz the power

6 years, 2 months ago (2014-09-25 08:18:40 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/497416b6baae8a66fa850aa80f96c1005d7e28e7
Cr-Commit-Position: refs/heads/master@{#296679}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages