Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(796)

Issue 602563002: [turbofan] Add length operand to LoadElement and StoreElement. (Closed)

Created:
6 years, 3 months ago by Benedikt Meurer
Modified:
6 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] Add length operand to LoadElement and StoreElement. This is preliminary work, required to properly support bounds checking for typed array loads/stores. TEST=compiler-unittests,cctest R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24172

Patch Set 1 #

Total comments: 2

Patch Set 2 : Improve test-simplified-lowering. #

Patch Set 3 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+250 lines, -54 lines) Patch
M src/compiler/generic-node.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/compiler/generic-node-inl.h View 1 chunk +10 lines, -0 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 2 1 chunk +1 line, -8 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 3 chunks +8 lines, -4 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 4 chunks +7 lines, -3 lines 0 comments Download
M src/compiler/simplified-operator.h View 3 chunks +13 lines, -2 lines 0 comments Download
M src/compiler/simplified-operator.cc View 3 chunks +38 lines, -6 lines 0 comments Download
M src/compiler/simplified-operator-unittest.cc View 2 chunks +105 lines, -0 lines 0 comments Download
M test/cctest/compiler/simplified-graph-builder.h View 1 chunk +6 lines, -4 lines 0 comments Download
M test/cctest/compiler/test-node.cc View 1 2 1 chunk +21 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 1 14 chunks +39 lines, -26 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Benedikt Meurer
6 years, 3 months ago (2014-09-24 08:41:48 UTC) #1
Benedikt Meurer
PTAL
6 years, 3 months ago (2014-09-24 08:49:56 UTC) #2
Michael Starzinger
Looking good. https://codereview.chromium.org/602563002/diff/1/src/compiler/generic-node.h File src/compiler/generic-node.h (right): https://codereview.chromium.org/602563002/diff/1/src/compiler/generic-node.h#newcode44 src/compiler/generic-node.h:44: inline void RemoveInput(int index); There is a ...
6 years, 3 months ago (2014-09-24 08:59:12 UTC) #3
Benedikt Meurer
https://codereview.chromium.org/602563002/diff/1/src/compiler/generic-node.h File src/compiler/generic-node.h (right): https://codereview.chromium.org/602563002/diff/1/src/compiler/generic-node.h#newcode44 src/compiler/generic-node.h:44: inline void RemoveInput(int index); On 2014/09/24 08:59:12, Michael Starzinger ...
6 years, 3 months ago (2014-09-24 09:24:48 UTC) #4
Michael Starzinger
LGTM.
6 years, 3 months ago (2014-09-24 09:28:29 UTC) #5
Benedikt Meurer
6 years, 3 months ago (2014-09-24 09:29:11 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 24172 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698