Chromium Code Reviews

Issue 602553002: Make type fuzzer return non-standard bitsets too. (Closed)

Created:
6 years, 3 months ago by neis
Modified:
6 years, 3 months ago
Reviewers:
rossberg
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Make type fuzzer return non-standard bitsets too. (Also speed up some types tests a little.) R=rossberg@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=24207

Patch Set 1 #

Total comments: 1

Patch Set 2 : Avoid generating a lot of None's #

Unified diffs Side-by-side diffs Stats (+25 lines, -14 lines)
M test/cctest/test-types.cc View 4 chunks +25 lines, -14 lines 0 comments

Messages

Total messages: 4 (0 generated)
neis
6 years, 3 months ago (2014-09-24 07:58:20 UTC) #1
rossberg
lgtm https://codereview.chromium.org/602553002/diff/1/test/cctest/test-types.cc File test/cctest/test-types.cc (right): https://codereview.chromium.org/602553002/diff/1/test/cctest/test-types.cc#newcode279 test/cctest/test-types.cc:279: return result; Hm, I wonder how many results ...
6 years, 3 months ago (2014-09-24 12:39:06 UTC) #2
rossberg
Still LGTM
6 years, 3 months ago (2014-09-24 17:22:00 UTC) #3
neis
6 years, 3 months ago (2014-09-25 08:03:34 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 24207 (presubmit successful).

Powered by Google App Engine