Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(932)

Issue 60253004: bookmarks: Reuse data member |model_| in ShowContextMenuForView() function. (Closed)

Created:
7 years, 1 month ago by tfarina
Modified:
7 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

bookmarks: Reuse data member |model_| in ShowContextMenuForView() function. We don't need to call BookmarkModelFactory::GetProfile(...) again as we already have a data member |model_| for which we have already called BookmarkModelFactory::GetProfile(). BUG=None TEST=In Bookmarks Bar, right click a folder that is not the "Other bookmarks", make sure that folder has only one children, for that folder the menu should not close when deleting the child node. Now do the same for the "Other bookmarks" folder, it should close if it has only one children. No regressions observed. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233412

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tfarina
I had this sitting in a local branch for a long time. Is this OK? ...
7 years, 1 month ago (2013-11-06 00:53:30 UTC) #1
sky
LGTM
7 years, 1 month ago (2013-11-06 14:12:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/60253004/1
7 years, 1 month ago (2013-11-06 16:06:50 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=95076
7 years, 1 month ago (2013-11-06 20:20:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/60253004/1
7 years, 1 month ago (2013-11-06 21:00:27 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-11-06 23:07:50 UTC) #6
Message was sent while issue was closed.
Change committed as 233412

Powered by Google App Engine
This is Rietveld 408576698