components/data_reduction_proxy/common/data_reduction_proxy_headers_unittest.cc - Issue 602503002: Adds UMA to measure when the data reduction proxy via header is missing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/common/data_reduction_proxy_headers_unittest.cc

Issue 602503002: Adds UMA to measure when the data reduction proxy via header is missing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove DCHECKs from tests Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/common/data_reduction_proxy_headers_test_utils.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/common/data_reduction_proxy_headers_unittest.cc

diff --git a/components/data_reduction_proxy/common/data_reduction_proxy_headers_unittest.cc b/components/data_reduction_proxy/common/data_reduction_proxy_headers_unittest.cc

index 61bad7e5b15cca8e24268b2a6d4206ecee677d64..a8984cea7dc64e4d8538f6774c8ce9c51e271fc7 100644

--- a/components/data_reduction_proxy/common/data_reduction_proxy_headers_unittest.cc

+++ b/components/data_reduction_proxy/common/data_reduction_proxy_headers_unittest.cc

@@ -6,22 +6,11 @@

#include <vector>

+#include "components/data_reduction_proxy/common/data_reduction_proxy_headers_test_utils.h"

#include "net/http/http_response_headers.h"

#include "net/proxy/proxy_service.h"

#include "testing/gtest/include/gtest/gtest.h"

-namespace {

-// Transform "normal"-looking headers (\n-separated) to the appropriate

-// input format for ParseRawHeaders (\0-separated).

-void HeadersToRaw(std::string* headers) {

- std::replace(headers->begin(), headers->end(), '\n', '\0');

- if (!headers->empty())

- *headers += '\0';

-} // namespace

namespace data_reduction_proxy {

class DataReductionProxyHeadersTest : public testing::Test {};