components/data_reduction_proxy/browser/data_reduction_proxy_protocol.cc - Issue 602503002: Adds UMA to measure when the data reduction proxy via header is missing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/browser/data_reduction_proxy_protocol.cc

Issue 602503002: Adds UMA to measure when the data reduction proxy via header is missing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove DCHECKs from tests Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy.gypi ('k') | components/data_reduction_proxy/browser/data_reduction_proxy_protocol_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/browser/data_reduction_proxy_protocol.cc

diff --git a/components/data_reduction_proxy/browser/data_reduction_proxy_protocol.cc b/components/data_reduction_proxy/browser/data_reduction_proxy_protocol.cc

index 565621d6af42db561f6a429383c5aabe4f60860a..b638c2cfe5fa5a1f27604bae2c1553d7d33f4ccb 100644

--- a/components/data_reduction_proxy/browser/data_reduction_proxy_protocol.cc

+++ b/components/data_reduction_proxy/browser/data_reduction_proxy_protocol.cc

@@ -65,6 +65,12 @@ bool MaybeBypassProxyAndPrepareToRetry(

if (data_reduction_proxy_type_info.proxy_servers.first.is_empty())

return false;

+ // At this point, the response is expected to have the data reduction proxy

+ // via header, so detect and report cases where the via header is missing.

+ DataReductionProxyUsageStats::DetectAndRecordMissingViaHeaderResponseCode(

+ !data_reduction_proxy_type_info.proxy_servers.second.is_empty(),

+ original_response_headers);

DataReductionProxyTamperDetection::DetectAndReport(

original_response_headers,

data_reduction_proxy_type_info.proxy_servers.first.SchemeIsSecure());