tools/metrics/histograms/histograms.xml - Issue 602503002: Adds UMA to measure when the data reduction proxy via header is missing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 602503002: Adds UMA to measure when the data reduction proxy via header is missing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

« components/data_reduction_proxy/browser/data_reduction_proxy_usage_stats_unittest.cc ('K') | « components/data_reduction_proxy/common/data_reduction_proxy_headers_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 92112143d135f7434cc40bb90f20e4aef1825a81..f30a994829901cf3b92898ca703e82538b109930 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -3582,6 +3582,27 @@ Therefore, the affected-histogram name has to have at least one dot in it.

</summary>

</histogram>

+<histogram name="DataReductionProxy.MissingViaHeader.Bytes" units="bytes">

+ <owner>bengr@chromium.org</owner>

+ <owner>sclittle@chromium.org</owner>

+ <summary>

+ Counts the response bytes of responses that Chrome expected to come through

+ a data reduction proxy and have the data reduction proxy via header, but

+ where the data reduction proxy via header was missing. Note that this does

+ not include responses that were bypassed.

+ </summary>

+</histogram>

+<histogram name="DataReductionProxy.MissingViaHeader.ResponseCode">

+ <owner>bengr@chromium.org</owner>

+ <owner>sclittle@chromium.org</owner>

+ <summary>

+ Counts the different HTTP response codes of responses that Chrome expected

+ to come through a data reduction proxy and have the data reduction proxy via

+ header, but where the data reduction proxy via header was missing.

+ </summary>

+</histogram>

<histogram name="DataReductionProxy.NetworkChangeEvents"

enum="DataReductionProxyNetworkChangeEvent">

<owner>bengr@chromium.org</owner>

@@ -53120,6 +53141,20 @@ To add a new entry, add it with any value and run test to compute valid value.

<affected-histogram name="DataReductionProxy.BypassedBytes"/>

</histogram_suffixes>

+<histogram_suffixes name="DataReductionProxyMissingViaHeaderBytes"

+ separator=".">

+ <suffix name="4xx" label="Response with 4xx response code"/>

+ <suffix name="Other" label="Other response"/>

+ <affected-histogram name="DataReductionProxy.MissingViaHeader.Bytes"/>

+</histogram_suffixes>

+<histogram_suffixes name="DataReductionProxyMissingViaHeaderResponseCode"

+ separator=".">

+ <suffix name="Primary" label="Primary data reduction proxy"/>

+ <suffix name="Fallback" label="Fallback data reduction proxy"/>

+ <affected-histogram name="DataReductionProxy.MissingViaHeader.ResponseCode"/>

+</histogram_suffixes>

<histogram_suffixes name="DefaultAppsExperiment">