Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 602453002: Valgrind: Widen a few existing suppressions and add a few new ones for HitTests and Mac flakiness. (Closed)

Created:
6 years, 3 months ago by Lei Zhang
Modified:
6 years, 3 months ago
Reviewers:
groby-ooo-7-16
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Valgrind: Widen a few existing suppressions and add a few new ones for HitTests and Mac flakiness. BUG=17540, 385396, 411235, 416957, 417048 NOTRY=true TBR=groby@chromium.org Committed: https://crrev.com/665d08e90954b8551e21e27f9b6f739e165d2f0a Cr-Commit-Position: refs/heads/master@{#296305}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -2 lines) Patch
M tools/valgrind/memcheck/suppressions.txt View 4 chunks +57 lines, -2 lines 2 comments Download
M tools/valgrind/memcheck/suppressions_mac.txt View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Lei Zhang
TBR
6 years, 3 months ago (2014-09-23 23:47:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/602453002/1
6 years, 3 months ago (2014-09-23 23:48:28 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as e86d1ebd6b1b5a29956764d2f49aaf705ab436e3
6 years, 3 months ago (2014-09-23 23:49:59 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/665d08e90954b8551e21e27f9b6f739e165d2f0a Cr-Commit-Position: refs/heads/master@{#296305}
6 years, 3 months ago (2014-09-23 23:50:37 UTC) #5
groby-ooo-7-16
lgtm https://codereview.chromium.org/602453002/diff/1/tools/valgrind/memcheck/suppressions.txt File tools/valgrind/memcheck/suppressions.txt (right): https://codereview.chromium.org/602453002/diff/1/tools/valgrind/memcheck/suppressions.txt#newcode563 tools/valgrind/memcheck/suppressions.txt:563: fun:_ZN3IPC*Channel*ConnectEv Shouldn't that simply get rid of ChannelImpl ...
6 years, 3 months ago (2014-09-23 23:56:39 UTC) #6
Lei Zhang
6 years, 3 months ago (2014-09-24 00:04:40 UTC) #7
Message was sent while issue was closed.
https://codereview.chromium.org/602453002/diff/1/tools/valgrind/memcheck/supp...
File tools/valgrind/memcheck/suppressions.txt (right):

https://codereview.chromium.org/602453002/diff/1/tools/valgrind/memcheck/supp...
tools/valgrind/memcheck/suppressions.txt:563: fun:_ZN3IPC*Channel*ConnectEv
On 2014/09/23 23:56:39, groby wrote:
> Shouldn't that simply get rid of ChannelImpl in the call chain? Or are there
> more things caught by this?

The ChannelImpl::Connect() call is gone. Channel::Connect() has become
ChannelPosix::Connect(), but I'm just wildcarding it in case the frame has minor
changes in the future.

Powered by Google App Engine
This is Rietveld 408576698