Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 602433002: [GN Build] Fix //net target on Mac (Closed)

Created:
6 years, 3 months ago by Ilya Sherman
Modified:
6 years, 2 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[GN Build] Fix //net target on Mac Exclude more targets from openssl build. BUG=none TEST=none R=jamesr@chromium.org Committed: https://crrev.com/7e5de4429a1ca1164b2fb45acf90d1984a62bb72 Cr-Commit-Position: refs/heads/master@{#296815}

Patch Set 1 #

Patch Set 2 : Turns out the desired simplification was not semanitcally valid. #

Patch Set 3 : Only remove keygen_handler_openssl.cc in one place #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M net/BUILD.gn View 1 2 3 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
Ilya Sherman
6 years, 3 months ago (2014-09-23 23:17:02 UTC) #1
jamesr
lgtm
6 years, 3 months ago (2014-09-23 23:42:48 UTC) #2
Ilya Sherman
+Raman for OWNERS approval
6 years, 3 months ago (2014-09-23 23:48:04 UTC) #4
ramant (doing other things)
lgtm
6 years, 3 months ago (2014-09-24 21:48:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/602433002/1
6 years, 3 months ago (2014-09-24 21:51:36 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/1960)
6 years, 3 months ago (2014-09-24 22:02:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/602433002/20001
6 years, 2 months ago (2014-09-25 00:00:33 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/2072)
6 years, 2 months ago (2014-09-25 00:16:15 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/602433002/40001
6 years, 2 months ago (2014-09-25 22:16:33 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 96a5235eeaa2f97c59691d735867d53b9e4958cf
6 years, 2 months ago (2014-09-25 23:02:38 UTC) #16
commit-bot: I haz the power
6 years, 2 months ago (2014-09-25 23:02:51 UTC) #17
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/7e5de4429a1ca1164b2fb45acf90d1984a62bb72
Cr-Commit-Position: refs/heads/master@{#296815}

Powered by Google App Engine
This is Rietveld 408576698