Source/core/editing/VisiblePosition.cpp - Issue 602423002: Mixing content editable and non-editable in direction RTL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/VisiblePosition.cpp

Issue 602423002: Mixing content editable and non-editable in direction RTL (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/editing/VisiblePosition.cpp

diff --git a/Source/core/editing/VisiblePosition.cpp b/Source/core/editing/VisiblePosition.cpp

index 6f43eafb0198aaad4089e7fbe8c8d828fd1176be..99339a89f72e277349f22e1206a637fee316a78b 100644

--- a/Source/core/editing/VisiblePosition.cpp

+++ b/Source/core/editing/VisiblePosition.cpp

@@ -281,7 +281,7 @@ VisiblePosition VisiblePosition::left(bool stayInEditableContent) const

return left;

// FIXME: This may need to do something different from "before".

yosin_UTC9 2014/09/29 01:29:03 Q: Can we remove this FIXME by this patch?

Habib Virji 2014/09/29 11:13:43 Done.

- return honorEditingBoundaryAtOrBefore(left);

+ return directionOfEnclosingBlock(left.deepEquivalent()) == LTR ? honorEditingBoundaryAtOrBefore(left) : honorEditingBoundaryAtOrAfter(left);

yosin_UTC9 2014/09/29 01:29:03 nit: It is better to use |isLeftToRightDirection(T

Habib Virji 2014/09/29 11:13:43 Done.

}

Position VisiblePosition::rightVisuallyDistinctCandidate() const

@@ -449,7 +449,7 @@ VisiblePosition VisiblePosition::right(bool stayInEditableContent) const

return right;

// FIXME: This may need to do something different from "after".

yosin_UTC9 2014/09/29 01:29:03 Q: Can we remove this FIXME by this patch?

Habib Virji 2014/09/29 11:13:43 Done.

- return honorEditingBoundaryAtOrAfter(right);

+ return directionOfEnclosingBlock(right.deepEquivalent()) == LTR ? honorEditingBoundaryAtOrAfter(right) : honorEditingBoundaryAtOrBefore(right);

yosin_UTC9 2014/09/29 01:29:03 nit: It is better to use |isLeftToRightDirection(T

Habib Virji 2014/09/29 11:13:43 Done.

}

VisiblePosition VisiblePosition::honorEditingBoundaryAtOrBefore(const VisiblePosition &pos) const

« no previous file with comments | « LayoutTests/editing/selection/skip-non-editable-rtl-expected.txt ('k') | no next file » | no next file with comments »