Mixing content editable and non-editable in direction RTL

Source/core/editing/htmlediting.cpp

 /*
  * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 333 matching lines @@
             return toElement(n);
     }
     return 0;
 }
 
 bool inSameContainingBlockFlowElement(Node* a, Node* b)
 {
     return a && b && enclosingBlockFlowElement(*a) == enclosingBlockFlowElement(*b);
 }
 
-TextDirection directionOfEnclosingBlock(const Position& position)
+bool isEnclosingBoxHasLeftToRightDirection(const Position& position)
 {
     Element* enclosingBlockElement = enclosingBlock(position.containerNode());
     if (!enclosingBlockElement)
-        return LTR;
+        return true;
     RenderObject* renderer = enclosingBlockElement->renderer();
-    return renderer ? renderer->style()->direction() : LTR;
+    return renderer ? (renderer->style()->direction() == LTR) : true;

[yosin, 2014/10/01 08:00:11]

nit: We don't need to use "?" operator here. We could write:
return !renderer || render->style()->direction == LTR

[Habib Virji, 2014/10/01 15:56:16]

Done.

 }
 
 // This method is used to create positions in the DOM. It returns the maximum valid offset
 // in a node. It returns 1 for some elements even though they do not have children, which
 // creates technically invalid DOM Positions. Be sure to call parentAnchoredEquivalent
 // on a Position before using it to create a DOM Range, or an exception will be thrown.
 int lastOffsetForEditing(const Node* node)
 {
     ASSERT(node);
     if (!node)
@@ skipping 854 matching lines @@
     // if the selection starts just before a paragraph break, skip over it
     if (isEndOfParagraph(visiblePosition))
         return visiblePosition.next().deepEquivalent().downstream();
 
     // otherwise, make sure to be at the start of the first selected node,
     // instead of possibly at the end of the last node before the selection
     return visiblePosition.deepEquivalent().downstream();
 }
 
 } // namespace blink