Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(771)

Issue 602403002: Roll breakpad r1387 -> r1388 for breakpad microdumps. (Closed)

Created:
6 years, 2 months ago by Primiano Tucci (use gerrit)
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Roll breakpad r1387 -> r1388 for breakpad microdumps. This picks up the microdump refactoring and updates the gyp/gn makefiles accordingly. SVN changes picked up by this roll: r1388: Microdumps: refactor out common parts of minidump_writer.cc BUG=410294 Committed: https://crrev.com/581bec84d7658893cdb0779243a3604d5e7d581f Cr-Commit-Position: refs/heads/master@{#297635}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M breakpad/BUILD.gn View 1 1 chunk +7 lines, -0 lines 0 comments Download
M breakpad/breakpad.gyp View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Primiano Tucci (use gerrit)
This is to pick up https://breakpad.appspot.com/4684002 and get coverage inside chromium waterfall. I tried building ...
6 years, 2 months ago (2014-10-01 10:13:25 UTC) #2
rmcilroy
On 2014/10/01 10:13:25, Primiano Tucci wrote: > This is to pick up https://breakpad.appspot.com/4684002 and get ...
6 years, 2 months ago (2014-10-01 10:22:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/602403002/20001
6 years, 2 months ago (2014-10-01 12:36:16 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/14709)
6 years, 2 months ago (2014-10-01 12:43:39 UTC) #7
Primiano Tucci (use gerrit)
Actually this requires Mark's OWNERS lgtm
6 years, 2 months ago (2014-10-01 12:50:16 UTC) #9
Mark Mentovai
LGTM
6 years, 2 months ago (2014-10-01 12:55:59 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/602403002/20001
6 years, 2 months ago (2014-10-01 13:43:15 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 0eeccdee92b5fe481b55246f54f37ead754fc734
6 years, 2 months ago (2014-10-01 13:46:37 UTC) #13
commit-bot: I haz the power
6 years, 2 months ago (2014-10-01 13:47:29 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/581bec84d7658893cdb0779243a3604d5e7d581f
Cr-Commit-Position: refs/heads/master@{#297635}

Powered by Google App Engine
This is Rietveld 408576698