chromecast/metrics/cast_metrics_service_client_unittest.cc - Issue 602393004: Chromecast: adds stability metrics provider to track crashes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/metrics/cast_metrics_service_client_unittest.cc

Issue 602393004: Chromecast: adds stability metrics provider to track crashes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: break common->metrics dependency Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chromecast/metrics/cast_metrics_prefs.cc ('K') | « chromecast/metrics/cast_metrics_service_client.cc ('k') | chromecast/metrics/cast_stability_metrics_provider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromecast/metrics/cast_metrics_service_client_unittest.cc

diff --git a/chromecast/metrics/cast_metrics_service_client_unittest.cc b/chromecast/metrics/cast_metrics_service_client_unittest.cc

index 55e59b001a4512345851fdeee80a04d301279d6f..e3d53734cbc057ae9b3797e2b8f4b9ca3448d6b3 100644

--- a/chromecast/metrics/cast_metrics_service_client_unittest.cc

+++ b/chromecast/metrics/cast_metrics_service_client_unittest.cc

@@ -25,6 +25,9 @@ class CastMetricsTest : public testing::Test {

::metrics::MetricsService::RegisterPrefs(prefs_->registry());

}

+ base::TaskRunner* task_runner() {

+ return message_loop_->task_runner().get();

+ }

TestingPrefServiceSimple* prefs() { return prefs_.get(); }

private:

@@ -36,7 +39,7 @@ class CastMetricsTest : public testing::Test {

TEST_F(CastMetricsTest, CreateMetricsServiceClient) {

// Create and expect this to not crash.

- metrics::CastMetricsServiceClient::Create(prefs(), NULL);

+ metrics::CastMetricsServiceClient::Create(task_runner(), prefs(), NULL);

}

} // namespace chromecast