Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Side by Side Diff: chromecast/common/chromecast_config.cc

Issue 602393004: Chromecast: adds stability metrics provider to track crashes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: DEPS changes not caught by git cl presubmit Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chromecast/chromecast.gyp ('k') | chromecast/common/pref_names.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chromecast/common/chromecast_config.h" 5 #include "chromecast/common/chromecast_config.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/files/file_util.h" 10 #include "base/files/file_util.h"
11 #include "base/logging.h" 11 #include "base/logging.h"
12 #include "base/path_service.h" 12 #include "base/path_service.h"
13 #include "base/prefs/json_pref_store.h" 13 #include "base/prefs/json_pref_store.h"
14 #include "base/prefs/pref_registry_simple.h" 14 #include "base/prefs/pref_registry_simple.h"
15 #include "base/prefs/pref_service_factory.h" 15 #include "base/prefs/pref_service_factory.h"
16 #include "base/prefs/pref_store.h" 16 #include "base/prefs/pref_store.h"
17 #include "base/strings/string_number_conversions.h" 17 #include "base/strings/string_number_conversions.h"
18 #include "chromecast/common/cast_paths.h" 18 #include "chromecast/common/cast_paths.h"
19 #include "chromecast/common/pref_names.h" 19 #include "chromecast/common/pref_names.h"
20 #include "chromecast/metrics/cast_metrics_prefs.h"
21 20
22 namespace chromecast { 21 namespace chromecast {
23 22
24 namespace { 23 namespace {
25 24
26 // Config file IO worker constants. 25 // Config file IO worker constants.
27 const int kNumOfConfigFileIOWorkers = 1; 26 const int kNumOfConfigFileIOWorkers = 1;
28 const char kNameOfConfigFileIOWorkers[] = "ConfigFileIO"; 27 const char kNameOfConfigFileIOWorkers[] = "ConfigFileIO";
29 28
30 void UserPrefsLoadError( 29 void UserPrefsLoadError(
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
68 // Explict writing before worker_pool shutdown. 67 // Explict writing before worker_pool shutdown.
69 pref_service_->CommitPendingWrite(); 68 pref_service_->CommitPendingWrite();
70 worker_pool_->Shutdown(); 69 worker_pool_->Shutdown();
71 } 70 }
72 71
73 bool ChromecastConfig::Load(PrefRegistrySimple* registry) { 72 bool ChromecastConfig::Load(PrefRegistrySimple* registry) {
74 DCHECK(thread_checker_.CalledOnValidThread()); 73 DCHECK(thread_checker_.CalledOnValidThread());
75 VLOG(1) << "Loading config from " << config_path_.value(); 74 VLOG(1) << "Loading config from " << config_path_.value();
76 registry->RegisterIntegerPref(prefs::kRemoteDebuggingPort, 0); 75 registry->RegisterIntegerPref(prefs::kRemoteDebuggingPort, 0);
77 76
78 metrics::RegisterPrefs(registry);
79 RegisterPlatformPrefs(registry); 77 RegisterPlatformPrefs(registry);
80 78
81 PersistentPrefStore::PrefReadError prefs_read_error = 79 PersistentPrefStore::PrefReadError prefs_read_error =
82 PersistentPrefStore::PREF_READ_ERROR_NONE; 80 PersistentPrefStore::PREF_READ_ERROR_NONE;
83 base::PrefServiceFactory prefServiceFactory; 81 base::PrefServiceFactory prefServiceFactory;
84 scoped_refptr<base::SequencedTaskRunner> task_runner = 82 scoped_refptr<base::SequencedTaskRunner> task_runner =
85 JsonPrefStore::GetTaskRunnerForFile(config_path_, worker_pool_.get()); 83 JsonPrefStore::GetTaskRunnerForFile(config_path_, worker_pool_.get());
86 prefServiceFactory.SetUserPrefsFile(config_path_, task_runner.get()); 84 prefServiceFactory.SetUserPrefsFile(config_path_, task_runner.get());
87 prefServiceFactory.set_async(false); 85 prefServiceFactory.set_async(false);
88 prefServiceFactory.set_read_error_callback( 86 prefServiceFactory.set_read_error_callback(
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
137 << ", value=" << value; 135 << ", value=" << value;
138 } 136 }
139 } 137 }
140 138
141 bool ChromecastConfig::HasValue(const std::string& key) const { 139 bool ChromecastConfig::HasValue(const std::string& key) const {
142 DCHECK(thread_checker_.CalledOnValidThread()); 140 DCHECK(thread_checker_.CalledOnValidThread());
143 return pref_service_->HasPrefPath(key.c_str()); 141 return pref_service_->HasPrefPath(key.c_str());
144 } 142 }
145 143
146 } // namespace chromecast 144 } // namespace chromecast
OLDNEW
« no previous file with comments | « chromecast/chromecast.gyp ('k') | chromecast/common/pref_names.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698