Make style building for 'font-family' less custom.

Make style building for 'font-family' less custom.

This patch changes style building for 'font-family', such that the
CSSValue -> FontFamily conversion happens on the outside, rather than
passing the CSSValue directly to the FontBuilder. This aligns building
of 'font-family' more with how everything else works, and also removes the
final dependency on CSSValue in FontBuilder.

The in-flight struct FontDescription::FamilyDescription is used to
transfer FontFamily+GenericFamilyType from StyleBuilder::applyProperty to
FontBuilder.

Note: The unrelated FIXME was intentionally removed. I don't consider it
valid (at least not anymore).

R=dglazkov@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182839

[dglazkov, 2014-09-26 17:52:53]

lgtm

https://codereview.chromium.org/602373003/diff/1/Source/core/css/resolver/Fon...
File Source/core/css/resolver/FontBuilder.cpp (right):

https://codereview.chromium.org/602373003/diff/1/Source/core/css/resolver/Fon...
Source/core/css/resolver/FontBuilder.cpp:141: AtomicString
FontBuilder::genericFontFamilyName(FontDescription::GenericFamilyType
genericFamily) const
AWESOME!!

[rune, 2014-09-26 19:54:48]

You should change FontBuiler -> FontBuilder in the description before you land.

An 'and' too much here?:

"... used to transfer FontFamily+GenericFamilyType from FontDescription and to
FontBuilder."

[andersr, 2014-09-29 08:55:21]

On 2014/09/26 at 19:54:48, rune wrote:
> You should change FontBuiler -> FontBuilder in the description before you
land.
> 
> An 'and' too much here?:
> 
> "... used to transfer FontFamily+GenericFamilyType from FontDescription and to
> FontBuilder."

Fixed.

[andersr, 2014-09-29 08:55:33]

The CQ bit was checked by andersr@opera.com

[commit-bot: I haz the power, 2014-09-29 08:56:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/602373003/1

[commit-bot: I haz the power, 2014-09-29 09:12:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-29 09:12:56]

Try jobs failed on following builders:
  android_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_db...)
  android_blink_compile_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_re...)
  android_chromium_gn_compile_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/android_chromium_gn_comp...)

[andersr, 2014-09-29 09:18:03]

The CQ bit was checked by andersr@opera.com

[commit-bot: I haz the power, 2014-09-29 09:20:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/602373003/20001

[commit-bot: I haz the power, 2014-09-29 12:14:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-29 12:14:46]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/29237)

[andersr, 2014-09-29 12:39:50]

The CQ bit was checked by andersr@opera.com

[commit-bot: I haz the power, 2014-09-29 12:40:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/602373003/20001

[commit-bot: I haz the power, 2014-09-29 13:20:47]

Committed patchset #2 (id:20001) as 182839