Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Issue 602353003: Article not exposed with correct IA2 Role (Closed)

Created:
6 years, 2 months ago by shreeramk
Modified:
6 years, 2 months ago
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Article not exposed with correct IA2 Role Article tag and aria role article are not exposed with correct IA2 Role. Correct IA2 role for article is ROLE_SYSTEM_DOCUMENT. BUG=281890 Committed: https://crrev.com/268e3314f0c3f4f45212857161fc0d5c3c618a2b Cr-Commit-Position: refs/heads/master@{#296908}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M content/browser/accessibility/browser_accessibility_win.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/test/data/accessibility/article-expected-win.txt View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
shreeramk
Please review. Thanks!
6 years, 2 months ago (2014-09-26 07:51:01 UTC) #2
dmazzoni
lgtm
6 years, 2 months ago (2014-09-26 08:15:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/602353003/1
6 years, 2 months ago (2014-09-26 08:16:14 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 6988ef8486ca9e25dae3674fe32c87051f242f28
6 years, 2 months ago (2014-09-26 09:18:37 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 09:19:23 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/268e3314f0c3f4f45212857161fc0d5c3c618a2b
Cr-Commit-Position: refs/heads/master@{#296908}

Powered by Google App Engine
This is Rietveld 408576698