Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 602353002: Removed duplicated virtual computePreferredLogicalWidths() (Closed)

Created:
6 years, 2 months ago by h.joshi
Modified:
6 years, 2 months ago
Reviewers:
pdr., eae
CC:
blink-reviews, blink-reviews-rendering, cbiesinger, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rune+blink, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Removed duplicated virtual computePreferredLogicalWidths() RenderDeprecatedFlexibleBox, RenderMenuList and RenderSlider does not need this duplicated code from RenderBlock. Now code will go through the updateFirstLetter() check but first letter is disabled for RenderDeprecatedFlexibleBox, RenderMenuList. This patch removes the overridden function. BUG=263225 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183174

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -88 lines) Patch
M Source/core/rendering/RenderDeprecatedFlexibleBox.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderDeprecatedFlexibleBox.cpp View 1 chunk +0 lines, -29 lines 0 comments Download
M Source/core/rendering/RenderMenuList.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderMenuList.cpp View 1 chunk +0 lines, -28 lines 1 comment Download
M Source/core/rendering/RenderSlider.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderSlider.cpp View 1 chunk +0 lines, -28 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
h.joshi
Pls review
6 years, 2 months ago (2014-10-02 03:38:28 UTC) #2
pdr.
Nice cleanup. LGTM https://codereview.chromium.org/602353002/diff/1/Source/core/rendering/RenderMenuList.cpp File Source/core/rendering/RenderMenuList.cpp (left): https://codereview.chromium.org/602353002/diff/1/Source/core/rendering/RenderMenuList.cpp#oldcode366 Source/core/rendering/RenderMenuList.cpp:366: LayoutUnit toAdd = borderAndPaddingWidth(); This is ...
6 years, 2 months ago (2014-10-02 04:21:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/602353002/1
6 years, 2 months ago (2014-10-02 04:22:10 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/builds/12351) win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/29812) mac_gpu ...
6 years, 2 months ago (2014-10-02 04:26:03 UTC) #7
pdr.
On 2014/10/02 at 04:26:03, commit-bot wrote: > Try jobs failed on following builders: > linux_chromium_gn_rel ...
6 years, 2 months ago (2014-10-02 04:37:04 UTC) #8
h.joshi
@pdr: Thank you for patch review.
6 years, 2 months ago (2014-10-03 01:46:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/602353002/1
6 years, 2 months ago (2014-10-03 01:48:00 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-03 02:47:03 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183174

Powered by Google App Engine
This is Rietveld 408576698