Issue 60233003: Move OpenTypeTypes to platform/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 60233003: Move OpenTypeTypes to platform/ (Closed)

Created:
7 years, 1 month ago by pilgrim_google

Modified:
7 years, 1 month ago

Reviewers:
abarth-chromium

CC:
blink-reviews, darin (slow to review)

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Move OpenTypeTypes to platform/ BUG=297477 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161374

Patch Set 1 #

Total comments: 1

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -103 lines)			Patch
M	Source/core/core.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	Source/core/platform/graphics/opentype/OpenTypeTypes.h	View	1 chunk	+0 lines, -101 lines	0 comments	Download
M	Source/core/platform/graphics/opentype/OpenTypeVerticalData.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/platform/blink_platform.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
A +	Source/platform/fonts/opentype/OpenTypeTypes.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	Source/web/tests/OpenTypeVerticalDataTest.cpp	View	1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

lgtm https://codereview.chromium.org/60233003/diff/1/Source/web/tests/OpenTypeVerticalDataTest.cpp File Source/web/tests/OpenTypeVerticalDataTest.cpp (right): https://codereview.chromium.org/60233003/diff/1/Source/web/tests/OpenTypeVerticalDataTest.cpp#newcode32 Source/web/tests/OpenTypeVerticalDataTest.cpp:32: #include "wtf/RefPtr.h" Can we move this test into ...

7 years, 1 month ago (2013-11-05 18:05:05 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/60233003/1

7 years, 1 month ago (2013-11-05 18:05:16 UTC) #3

Message was sent while issue was closed.

Change committed as 161374

Expand Messages | Collapse Messages