Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 602313002: Fix Aura tooltip sizing and layout. (Closed)

Created:
6 years, 2 months ago by msw
Modified:
6 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, ben+corewm_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix Aura tooltip sizing and layout. r296008 regressed TooltipAura vertical placement. (that change removed vertical centering of multi-line text) (TooltipAura implicitly used this for vertical padding) Add an actual border and explicit Label sizing instead. (this allocates space for the padding in the Label border) (it also base-line centers the text in the correct bounds) See before/after pics at http://crbug.com/417602#c5 BUG=417602 TEST=Chrome OS and "Windows 8 mode" Chrome tooltips look good. R=sky@chromium.org Committed: https://crrev.com/a23b072d5ecf5020d513a6d432cf9cfc080ea179 Cr-Commit-Position: refs/heads/master@{#296874}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -21 lines) Patch
M ui/views/corewm/tooltip_aura.h View 1 chunk +1 line, -2 lines 0 comments Download
M ui/views/corewm/tooltip_aura.cc View 6 chunks +13 lines, -19 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
msw
Hey Scott, please take a look; thanks!
6 years, 2 months ago (2014-09-26 02:14:03 UTC) #2
sky
LGTM
6 years, 2 months ago (2014-09-26 03:35:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/602313002/1
6 years, 2 months ago (2014-09-26 03:46:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 9553db2ad14a802d7208c50ff3adcee6d93e43c3
6 years, 2 months ago (2014-09-26 03:50:57 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 03:51:41 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a23b072d5ecf5020d513a6d432cf9cfc080ea179
Cr-Commit-Position: refs/heads/master@{#296874}

Powered by Google App Engine
This is Rietveld 408576698