Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 602293003: app_shell: build on any Linux, as there is no non-aura in the bot configurations. (Closed)

Created:
6 years, 2 months ago by Yoyo Zhou
Modified:
6 years, 2 months ago
Reviewers:
James Cook
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src@master
Project:
chromium
Visibility:
Public.

Description

app_shell: build on any Linux, as there is no non-aura in the bot configurations. Committed: https://crrev.com/94dbb777c583375f778b9d1ff9fb766d6102bf6b Cr-Commit-Position: refs/heads/master@{#297311}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/all.gyp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Yoyo Zhou
6 years, 2 months ago (2014-09-29 22:02:06 UTC) #2
James Cook
lgtm
6 years, 2 months ago (2014-09-29 22:50:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/602293003/20001
6 years, 2 months ago (2014-09-29 23:03:04 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 80c3c962b4fb230425132ce592bc1a241b6b9613
6 years, 2 months ago (2014-09-30 00:02:55 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 00:04:32 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/94dbb777c583375f778b9d1ff9fb766d6102bf6b
Cr-Commit-Position: refs/heads/master@{#297311}

Powered by Google App Engine
This is Rietveld 408576698