Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(54)

Issue 602203005: Handle fonts with missing ZWS glyph in simple text path (Closed)

Created:
5 years, 6 months ago by eae
Modified:
5 years, 6 months ago
CC:
blink-reviews, jamesr, pdr+graphicswatchlist_chromium.org, jbroman, mkwst+moarreviews_chromium.org, danakj, Rik, Stephen Chennney, krit, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Handle fonts with missing ZWS glyph in simple text path Some fonts do not have a glyph for zero width space, when that happens a "missing glyph" symbol is used instead which is undesirable. Instead fall back on the space glyph and set the width to zero. R=dominik.rottsches@intel.com BUG=334269 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182764

Patch Set 1 : #

Total comments: 1

Patch Set 2 : Remove pointless (and out of date) comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M Source/platform/fonts/WidthIterator.cpp View 1 1 chunk +13 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
eae
5 years, 6 months ago (2014-09-26 12:37:44 UTC) #2
eae
Ready for review.
5 years, 6 months ago (2014-09-26 12:49:21 UTC) #6
Dominik Röttsches
LGTM, great stuff, this marks the last remaining required change to land CoreText removal. Thanks! ...
5 years, 6 months ago (2014-09-26 12:56:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/602203005/60001
5 years, 6 months ago (2014-09-26 12:57:31 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:60001) as 182764
5 years, 6 months ago (2014-09-26 14:06:17 UTC) #10
behdad_google
5 years, 6 months ago (2014-09-30 16:57:45 UTC) #12
Message was sent while issue was closed.

          

Powered by Google App Engine
This is Rietveld 408576698