Refactoring: Let ChannelPosix adopt ScopedFD.

Refactoring: Let ChannelPosix adopt ScopedFD.

This gets rid of raw close() call usign base::ScopedFD.
Ownership of FDs become clearer.

This is a preparation for kiling base::FileDescriptor.

R=jam@chromium.org, agl@chromium.org
BUG=415294
Committed: https://crrev.com/ce44fef5fd60dd2be5c587d4b084bdcd36adcee4
Cr-Commit-Position: refs/heads/master@{#297285}

[jam, 2014-09-25 22:45:23]

I'm not a good reviewer here as I'm not familiar with that file.

[agl, 2014-09-25 22:55:58]

LGTM with nits.

https://codereview.chromium.org/602193004/diff/1/ipc/ipc_channel_posix.cc
File ipc/ipc_channel_posix.cc (right):

https://codereview.chromium.org/602193004/diff/1/ipc/ipc_channel_posix.cc#new...
ipc/ipc_channel_posix.cc:260: int local_pipe_fd;
This can be moved before L259.

https://codereview.chromium.org/602193004/diff/1/ipc/ipc_channel_posix.cc#new...
ipc/ipc_channel_posix.cc:266: local_pipe.reset(local_pipe_fd);
This can be moved after L279.

https://codereview.chromium.org/602193004/diff/1/ipc/ipc_channel_posix.cc#new...
ipc/ipc_channel_posix.cc:340: if ((mode_ & MODE_SERVER_FLAG) && (mode_ &
MODE_NAMED_FLAG))
{ } for bodies when if ... else ...

[Hajime Morrita, 2014-09-29 20:01:16]

The CQ bit was checked by morrita@chromium.org

[commit-bot: I haz the power, 2014-09-29 20:01:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/602193004/20001

[commit-bot: I haz the power, 2014-09-29 22:26:05]

Committed patchset #2 (id:20001) as 6f2689b07f0de1cb8da3d330ad555892aca64d59

[commit-bot: I haz the power, 2014-09-29 22:26:54]

Patchset 2 (id:??) landed as
https://crrev.com/ce44fef5fd60dd2be5c587d4b084bdcd36adcee4
Cr-Commit-Position: refs/heads/master@{#297285}