Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1140)

Unified Diff: media/base/audio_converter.cc

Issue 602193003: Cleanup some audio classes with C++11 shine! (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/audio_converter.cc
diff --git a/media/base/audio_converter.cc b/media/base/audio_converter.cc
index aa0be4f0470c511512022c9f6d33e27eb2d104ff..194111914e0d05ec14f1fb8c5e5833d150554cb1 100644
--- a/media/base/audio_converter.cc
+++ b/media/base/audio_converter.cc
@@ -197,14 +197,11 @@ void AudioConverter::SourceCallback(int fifo_frame_delay, AudioBus* dest) {
transform_inputs_.size() == 1 ? temp_dest : mixer_input_audio_bus_.get();
// Have each mixer render its data into an output buffer then mix the result.
- for (InputCallbackSet::iterator it = transform_inputs_.begin();
- it != transform_inputs_.end(); ++it) {
- InputCallback* input = *it;
-
+ for (auto* input : transform_inputs_) {
const float volume = input->ProvideInput(provide_input_dest, buffer_delay);
// Optimize the most common single input, full volume case.
- if (it == transform_inputs_.begin()) {
+ if (input == transform_inputs_.front()) {
if (volume == 1.0f) {
if (temp_dest != provide_input_dest)
provide_input_dest->CopyTo(temp_dest);

Powered by Google App Engine
This is Rietveld 408576698