Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: extensions/renderer/resources/web_view_events.js

Issue 602193002: Fix for how webview.executeScript and webivew.insertCSS check for page navigtation when loading dat… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/resources/web_view_events.js
diff --git a/extensions/renderer/resources/web_view_events.js b/extensions/renderer/resources/web_view_events.js
index 137baa2ee45e469dcaf1df7a4d9bcda1ecc83cfd..422a1a7bbefa02bc860fac95ce16a100cacb7358 100644
--- a/extensions/renderer/resources/web_view_events.js
+++ b/extensions/renderer/resources/web_view_events.js
@@ -297,12 +297,13 @@ WebViewEvents.prototype.handleLoadAbortEvent = function(event, webViewEvent) {
window.console.warn(WARNING_MSG_LOAD_ABORTED.replace('%1', reason));
};
if (this.webViewInternal.dispatchEvent(webViewEvent)) {
- showWarningMessage(event.reason);
+ showWarningMessqage(event.reason);
Fady Samuel 2014/09/25 20:09:03 What happened here?
paulmeyer 2014/09/25 20:39:51 Looks like a misguided 'q' got inserted here. My g
}
};
WebViewEvents.prototype.handleLoadCommitEvent = function(event, webViewEvent) {
- this.webViewInternal.onLoadCommit(event.currentEntryIndex, event.entryCount,
+ this.webViewInternal.onLoadCommit(event.baseURLForDataURL,
+ event.currentEntryIndex, event.entryCount,
event.processId, event.url,
event.isTopLevel);
this.webViewInternal.dispatchEvent(webViewEvent);
« extensions/renderer/resources/web_view.js ('K') | « extensions/renderer/resources/web_view.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698