Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Side by Side Diff: extensions/renderer/resources/web_view_events.js

Issue 602193002: Fix for how webview.executeScript and webivew.insertCSS check for page navigtation when loading dat… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Comments. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « extensions/renderer/resources/web_view.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Event management for WebViewInternal. 5 // Event management for WebViewInternal.
6 6
7 var EventBindings = require('event_bindings'); 7 var EventBindings = require('event_bindings');
8 var MessagingNatives = requireNative('messaging_natives'); 8 var MessagingNatives = requireNative('messaging_natives');
9 var WebView = require('webViewInternal').WebView; 9 var WebView = require('webViewInternal').WebView;
10 10
(...skipping 284 matching lines...) Expand 10 before | Expand all | Expand 10 after
295 var WARNING_MSG_LOAD_ABORTED = '<webview>: ' + 295 var WARNING_MSG_LOAD_ABORTED = '<webview>: ' +
296 'The load has aborted with reason "%1".'; 296 'The load has aborted with reason "%1".';
297 window.console.warn(WARNING_MSG_LOAD_ABORTED.replace('%1', reason)); 297 window.console.warn(WARNING_MSG_LOAD_ABORTED.replace('%1', reason));
298 }; 298 };
299 if (this.webViewInternal.dispatchEvent(webViewEvent)) { 299 if (this.webViewInternal.dispatchEvent(webViewEvent)) {
300 showWarningMessage(event.reason); 300 showWarningMessage(event.reason);
301 } 301 }
302 }; 302 };
303 303
304 WebViewEvents.prototype.handleLoadCommitEvent = function(event, webViewEvent) { 304 WebViewEvents.prototype.handleLoadCommitEvent = function(event, webViewEvent) {
305 this.webViewInternal.onLoadCommit(event.currentEntryIndex, event.entryCount, 305 this.webViewInternal.onLoadCommit(event.baseUrlForDataUrl,
306 event.currentEntryIndex, event.entryCount,
306 event.processId, event.url, 307 event.processId, event.url,
307 event.isTopLevel); 308 event.isTopLevel);
308 this.webViewInternal.dispatchEvent(webViewEvent); 309 this.webViewInternal.dispatchEvent(webViewEvent);
309 }; 310 };
310 311
311 WebViewEvents.prototype.handleNewWindowEvent = function(event, webViewEvent) { 312 WebViewEvents.prototype.handleNewWindowEvent = function(event, webViewEvent) {
312 var ERROR_MSG_NEWWINDOW_ACTION_ALREADY_TAKEN = '<webview>: ' + 313 var ERROR_MSG_NEWWINDOW_ACTION_ALREADY_TAKEN = '<webview>: ' +
313 'An action has already been taken for this "newwindow" event.'; 314 'An action has already been taken for this "newwindow" event.';
314 315
315 var ERROR_MSG_NEWWINDOW_UNABLE_TO_ATTACH = '<webview>: ' + 316 var ERROR_MSG_NEWWINDOW_UNABLE_TO_ATTACH = '<webview>: ' +
(...skipping 206 matching lines...) Expand 10 before | Expand all | Expand 10 after
522 } 523 }
523 }; 524 };
524 525
525 WebViewEvents.prototype.handleSizeChangedEvent = function( 526 WebViewEvents.prototype.handleSizeChangedEvent = function(
526 event, webViewEvent) { 527 event, webViewEvent) {
527 this.webViewInternal.onSizeChanged(webViewEvent); 528 this.webViewInternal.onSizeChanged(webViewEvent);
528 }; 529 };
529 530
530 exports.WebViewEvents = WebViewEvents; 531 exports.WebViewEvents = WebViewEvents;
531 exports.CreateEvent = CreateEvent; 532 exports.CreateEvent = CreateEvent;
OLDNEW
« no previous file with comments | « extensions/renderer/resources/web_view.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698