ui/views/widget/desktop_aura/x11_desktop_handler.cc - Issue 602183003: Do not consider WMII as supporting _NET_ACTIVE_WINDOW

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/widget/desktop_aura/x11_desktop_handler.cc

Issue 602183003: Do not consider WMII as supporting _NET_ACTIVE_WINDOW (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/widget/desktop_aura/x11_desktop_handler.cc

diff --git a/ui/views/widget/desktop_aura/x11_desktop_handler.cc b/ui/views/widget/desktop_aura/x11_desktop_handler.cc

index e4f6dea73ecc0d87b2cc0f8d9e1234c6e21d2827..df4276240a6181c1d831ac27d988d198cdee2ad4 100644

--- a/ui/views/widget/desktop_aura/x11_desktop_handler.cc

+++ b/ui/views/widget/desktop_aura/x11_desktop_handler.cc

@@ -58,8 +58,12 @@ X11DesktopHandler::X11DesktopHandler()

attr.your_event_mask | PropertyChangeMask |

StructureNotifyMask | SubstructureNotifyMask);

+ // Some window managers (e.g. wmii) say they support _NET_ACTIVE_WINDOW but

+ // do not. See http://crbug.com/417767

+ XID active_window;

wm_supports_active_window_ =

- ui::WmSupportsHint(atom_cache_.GetAtom("_NET_ACTIVE_WINDOW"));

+ ui::WmSupportsHint(atom_cache_.GetAtom("_NET_ACTIVE_WINDOW")) &&

+ ui::GetXIDProperty(x_root_window_, "_NET_ACTIVE_WINDOW", &active_window);

sadrul 2014/09/25 20:41:48 What if chrome is the first app the user launches?

}

X11DesktopHandler::~X11DesktopHandler() {

« no previous file with comments | « no previous file | no next file » | no next file with comments »